[ClassLoader][HttpKernel] Remove ClassLoader component & Kernel::loadClassCache #22786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ❤️ this part, when we remove stuff and everything continues working fine. Let's go, cleanup, bye to BC layers 😄 |
ogizanagi
changed the title
|
missing CHANGELOG updates in components (please check any your other PRs also if any) |
|
Added one in HttpKernel: https://github.com/symfony/symfony/pull/22786/files#diff-776debe25c0a772039d45b8d692c9dbfR7. Thanks. |
xabbuh
reviewed
May 20, 2017
| @@ -8,6 +8,7 @@ CHANGELOG | |||
| * removed `TraceableControllerResolver::getArguments()` | |||
| * removed `ControllerResolver::getArguments()` and the ability to resolve arguments | |||
| * removed the `argument_resolver` service dependency from the `debug.controller_resolver` | |||
| * removed `Extension::addClassesToCompile()` | |||
There was a problem hiding this comment.
Extension:: getClassesToCompile() too
There was a problem hiding this comment.
loadClassCache() and setClassCache() of the Kernel class have been removed too
|
rebase needed |
…ClassCache BC layer
(cherry picked from commit c365ae2)
|
Rebased. |
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
… & Kernel::loadClassCache (ogizanagi, xabbuh) This PR was merged into the 4.0-dev branch. Discussion ---------- [ClassLoader][HttpKernel] Remove ClassLoader component & Kernel::loadClassCache | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? |no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20735 | License | MIT | Doc PR | N/A As deprecated in #20735 Commits ------- 551aaef [ClassLoader] remove the component 4f8916c [ClassLoader][HttpKernel] Remove ClassCollectionLoader & Kernel::loadClassCache BC layer
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As deprecated in #20735