[Ldap] remove deprecated features #22797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
May 20, 2017
xabbuh
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
ldap-remove-deprecated-features
branch
2 times, most recently
from
4ba3e2c
to
3b25fd9
Compare
|
The CHANGELOG file needs an update (same for all the other PR I guess?) |
xabbuh
force-pushed
the
ldap-remove-deprecated-features
branch
from
3b25fd9
to
02d261e
Compare
|
changelog entries added (and I opened #22802 to actually create one for the component in the |
|
FC layer missing in 3.4? |
|
see #22813 |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [Security] do not mock a deprecated interface | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22797 (comment) | License | MIT | Doc PR | Commits ------- a920274 do not mock a deprecated interface
xabbuh
force-pushed
the
ldap-remove-deprecated-features
branch
from
02d261e
to
0813e14
Compare
|
Tests are green. Ready to be reviewed. |
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
May 21, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [Ldap] remove deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 0813e14 [Ldap] remove deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.