New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] Remove line number in deprecation notices #23108

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Member

nicolas-grekas commented Jun 8, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

While moving an app to 3.3, I noticed that my deprecation log is full of deprecation notices that differ only by some line number, but don't tell which file is concerned.
This makes the line number useless, and just prevents aggregation.

capture du 2017-06-08 16-29-31

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Jun 8, 2017

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jun 8, 2017

Member

👍

Member

stof commented Jun 8, 2017

👍

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jun 9, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented Jun 9, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f82b618 into symfony:3.3 Jun 9, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 9, 2017

bug #23108 [Yaml] Remove line number in deprecation notices (nicolas-…
…grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] Remove line number in deprecation notices

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

While moving an app to 3.3, I noticed that my deprecation log is full of deprecation notices that differ only by some line number, but don't tell which file is concerned.
This makes the line number useless, and just prevents aggregation.

![capture du 2017-06-08 16-29-31](https://user-images.githubusercontent.com/243674/26933795-dd123476-4c67-11e7-8cf3-406bedab9130.png)

Commits
-------

f82b618 [Yaml] Remove line number in deprecation notices
@rvanlaak

This comment has been minimized.

Show comment
Hide comment
@rvanlaak

rvanlaak Jun 12, 2017

Contributor

Although I 👍 with the MR, I think the line numbers would be really helpful. Maybe in a more verbose SYMFONY_DEPRECATIONS_HELPER mode? That would require discussion, @nicolas-grekas let me know if you think we should create a separate issue for that?

Contributor

rvanlaak commented Jun 12, 2017

Although I 👍 with the MR, I think the line numbers would be really helpful. Maybe in a more verbose SYMFONY_DEPRECATIONS_HELPER mode? That would require discussion, @nicolas-grekas let me know if you think we should create a separate issue for that?

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:yaml-aggreg branch Jun 12, 2017

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jun 12, 2017

Member

@rvanlaak SYMFONY_DEPRECATIONS_HELPER does not control the messages triggered in the code itself. It only configures the report in the PHPUnit bridge (and has no effect on the reporting in the profiler and logger btw)

Member

stof commented Jun 12, 2017

@rvanlaak SYMFONY_DEPRECATIONS_HELPER does not control the messages triggered in the code itself. It only configures the report in the PHPUnit bridge (and has no effect on the reporting in the profiler and logger btw)

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Jun 12, 2017

Member

An without the file, line numbers are useless...

Member

nicolas-grekas commented Jun 12, 2017

An without the file, line numbers are useless...

@fabpot fabpot referenced this pull request Jul 4, 2017

Merged

Release v3.3.3 #23369

nicolas-grekas added a commit that referenced this pull request Sep 29, 2017

bug #24191 [DependencyInjection] include file and line number in depr…
…ecation (xabbuh)

This PR was merged into the 3.3 branch.

Discussion
----------

[DependencyInjection] include file and line number in deprecation

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

In #23108 we removed line numbers from deprecation messages created by the YAML parser because those numbers were quite useless without the file being parsed. I suggest to revert this change and add the file being parsed to the deprecation message.

Commits
-------

cf03552 include file and line number in deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment