[DI] Fix keys resolution in ResolveParameterPlaceHoldersPass #23141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 12, 2017
| $value->setProperties($this->bag->resolveValue($value->getProperties())); | ||
| $value->setMethodCalls($this->bag->resolveValue($value->getMethodCalls())); | ||
| } | ||
| if (is_array($value = parent::processValue($value, $isRoot)) && $value) { |
There was a problem hiding this comment.
I would move the parent call outside the if, to be more clear (and remove potential mistakes where deciding to remove the handling of keys might also remove the parent call while it is always necessary)
stof
approved these changes
Jun 12, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 12, 2017
…ss (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [DI] Fix keys resolution in ResolveParameterPlaceHoldersPass | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Keys are resolved in 3.2, but we broke that when moving to AbstractRecursivePass. Commits ------- 9251a21 [DI] Fix keys resolution in ResolveParameterPlaceHoldersPass
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys are resolved in 3.2, but we broke that when moving to AbstractRecursivePass.