Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validator] replace hardcoded service id #23226

Merged
merged 1 commit into from Jun 19, 2017
Merged

[Validator] replace hardcoded service id #23226

merged 1 commit into from Jun 19, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 19, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23224
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.3 milestone Jun 19, 2017
@xabbuh xabbuh mentioned this pull request Jun 19, 2017
Closed
@Tobion
Copy link
Member

Tobion commented Jun 19, 2017

👍

chalasr
chalasr approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@fabpot
Copy link
Member

fabpot commented Jun 19, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 44ff4b1 into symfony:3.3 Jun 19, 2017
fabpot added a commit that referenced this pull request Jun 19, 2017
@fabpot
bug #23226 [Validator] replace hardcoded service id (xabbuh)
f89047d 
This PR was merged into the 3.3 branch.

Discussion
----------

[Validator] replace hardcoded service id

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23224
| License       | MIT
| Doc PR        |

Commits
-------

44ff4b1 [Validator] replace hardcoded service id
@xabbuh xabbuh deleted the issue-23224 branch June 19, 2017 17:19
@fabpot fabpot mentioned this pull request Jul 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Status: Needs Review Validator
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xabbuh @Tobion @fabpot @stof @ogizanagi @chalasr @carsonbot