Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBundle] add back exception check #23283

Merged
merged 1 commit into from Jun 24, 2017
Merged

[TwigBundle] add back exception check #23283

merged 1 commit into from Jun 24, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 24, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23268
License MIT
Doc PR

#23268 introduced a regression in that the full exception page was not shown anymore in case a template for the given format (if not html) could not be found.

@fabpot
Copy link
Member

fabpot commented Jun 24, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit 46c38df into symfony:2.7 Jun 24, 2017
fabpot added a commit that referenced this pull request Jun 24, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBundle] add back exception check

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23268
| License       | MIT
| Doc PR        |

#23268 introduced a regression in that the full exception page was not shown anymore in case a template for the given format (if not `html`) could not be found.

Commits
-------

46c38df [TwigBundle] add back exception check
@xabbuh xabbuh deleted the pr-23268 branch June 24, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants