Show exception is checked twice in ExceptionController of twig #23268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jun 22, 2017
|
Thank you @gmponos. |
fabpot
added a commit
that referenced
this pull request
Jun 22, 2017
…twig (gmponos) This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #23268). Discussion ---------- Show exception is checked twice in ExceptionController of twig | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | N/A I think that the $showException variable is checked twice. Check line 105 of the same file. Hope I did not miss anythings since the tests are passing. Commits ------- a433cec Show exception is checked twice in ExceptionController of twig
|
I think the check is still needed for the case when |
|
👊 You are right. There should have been a test for this. Good thing you added it. Maybe this |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [TwigBundle] add back exception check | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23268 | License | MIT | Doc PR | #23268 introduced a regression in that the full exception page was not shown anymore in case a template for the given format (if not `html`) could not be found. Commits ------- 46c38df [TwigBundle] add back exception check
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the $showException variable is checked twice. Check line 105 of the same file. Hope I did not miss anythings since the tests are passing.