[VarDumper] add force-collapse/expand + use it for traces #23967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
collapse-trace
branch
2 times, most recently
from
8ec15d0
to
615d725
Compare
|
PR ready, screenshot updated, now with less visual debt :) |
nicolas-grekas
force-pushed
the
collapse-trace
branch
from
615d725
to
3a60277
Compare
|
too much visual debt ! :p |
nicolas-grekas
force-pushed
the
collapse-trace
branch
from
3a60277
to
0e2d2b8
Compare
fabpot
approved these changes
Aug 31, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 31, 2017
…ces (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] add force-collapse/expand + use it for traces | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | - | License | MIT | Doc PR | - This improves dumping stack traces by expanding only frames that are outside of vendor dirs. Here the new CLI output (everything was expanded before):  And here is the HTML output, with toggle-able frames:  Todo: - [x] make tests pass :) Commits ------- 0e2d2b8 [VarDumper] add force-collapse/expand + use it for traces
This was referenced Oct 18, 2017
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Oct 29, 2017
…maxDepth (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] HtmlDumper: fix collapsing nodes with depth < maxDepth | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes (failures unrelated) | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This error happens since #23967: > (index):3 Uncaught TypeError: Cannot read property 'substr' of null https://github.com/symfony/symfony/blob/98dae3edb1ba8fa35c06a8c9a459e0ffb9105826/src/Symfony/Component/VarDumper/Dumper/HtmlDumper.php#L325 when trying to collapse the root node (or more precisely, the nodes with a depth <= maxDepth) because it misses one of the `sf-dump-expanded`/`sf-dump-compact` classes which are necessary for the toggling to work. Commits ------- a1863c3 [VarDumper] HtmlDumper: fix collapsing nodes with depth <= maxDepth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves dumping stack traces by expanding only frames that are outside of vendor dirs.
Here the new CLI output (everything was expanded before):
And here is the HTML output, with toggle-able frames:
Todo: