[HttpKernel] Make array vs "::" controller definitions consistent #24305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
route-array-controller
branch
from
ddc91fe
to
f0f9a66
Compare
ogizanagi
approved these changes
Sep 24, 2017
dunglas
approved these changes
Sep 24, 2017
|
Thank you @nicolas-grekas. |
ogizanagi
added a commit
that referenced
this pull request
Sep 24, 2017
…sistent (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [HttpKernel] Make array vs "::" controller definitions consistent | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Defining a controller using `[Foo::class, 'someAction']` vs `App\Controller\Foo::someAction` should end up produce the same result: a container lookup. Commits ------- f0f9a66 [HttpKernel] Make array vs "::" controller definitions consistent
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining a controller using
[Foo::class, 'someAction']vsApp\Controller\Foo::someActionshould end up produce the same result: a container lookup.