New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Make array vs "::" controller definitions consistent #24305

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Sep 24, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Defining a controller using [Foo::class, 'someAction'] vs App\Controller\Foo::someAction should end up produce the same result: a container lookup.

@ogizanagi

This comment has been minimized.

Show comment
Hide comment
@ogizanagi
Member

ogizanagi commented Sep 24, 2017

Thank you @nicolas-grekas.

@ogizanagi ogizanagi merged commit f0f9a66 into symfony:3.3 Sep 24, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

ogizanagi added a commit that referenced this pull request Sep 24, 2017

bug #24305 [HttpKernel] Make array vs "::" controller definitions con…
…sistent (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[HttpKernel] Make array vs "::" controller definitions consistent

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Defining a controller using `[Foo::class, 'someAction']` vs `App\Controller\Foo::someAction` should end up produce the same result: a container lookup.

Commits
-------

f0f9a66 [HttpKernel] Make array vs "::" controller definitions consistent

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:route-array-controller branch Sep 26, 2017

@fabpot fabpot referenced this pull request Oct 5, 2017

Merged

Release v3.3.10 #24452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment