debug:container --types: Fix bug with non-existent classes #24744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Oct 29, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Oct 29, 2017
… (weaverryan) This PR was merged into the 3.3 branch. Discussion ---------- debug:container --types: Fix bug with non-existent classes | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24639 | License | MIT | Doc PR | n/a I've just tested manually that this *does* fix the issue I described in #24639. Oddly enough, in a "stock" Flex project, after this patch, there is one *additional* "type" that's reported: > Symfony\Component\PropertyAccess\PropertyAccessorInterface alias for "property_accessor" That is a valid type... for some reason `interface_exists()` return false for this (??? maybe a quirk of my machine). Anyways, this is also "fixed" with this new approach. Commits ------- 4bb9d82 Fixing a bug where non-existent classes would cause issues
This was referenced Oct 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just tested manually that this does fix the issue I described in #24639.
Oddly enough, in a "stock" Flex project, after this patch, there is one additional "type" that's reported:
That is a valid type... for some reason
interface_exists()return false for this (??? maybe a quirk of my machine). Anyways, this is also "fixed" with this new approach.