Throwing exception if redis and predis unavailable #24758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the redis extension and predis are unavailable, line 137 throws an exception stating that \Predis\Client is not a class.
| @@ -108,6 +108,9 @@ public static function createConnection($dsn, array $options = array()) | |||
| $params += $query; | |||
| } | |||
| $params += $options + self::$defaultConnectionOptions; | |||
| if (null === $params['class'] && !extension_loaded('redis') && !class_exists(\Predis\Client::class)) { | |||
| throw new \RuntimeException(sprintf('Cannot find the "redis" extension, and "predis/predis" is not installed: %s', $dsn)); | |||
There was a problem hiding this comment.
Should throw in the Cache namespace.
nicolas-grekas
approved these changes
Oct 30, 2017
fabpot
approved these changes
Oct 30, 2017
|
Thank you @aequasi. |
fabpot
added a commit
that referenced
this pull request
Oct 30, 2017
This PR was squashed before being merged into the 3.3 branch (closes #24758). Discussion ---------- Throwing exception if redis and predis unavailable If the redis extension and predis are unavailable, line 137 throws an exception stating that \Predis\Client is not a class. | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none If the redis extension and predis are unavailable, the new line 137 throws an exception stating that \Predis\Client is not a class. Commits ------- e664c81 Throwing exception if redis and predis unavailable
This was referenced Nov 5, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the redis extension and predis are unavailable, line 137 throws an exception stating that \Predis\Client is not a class.
If the redis extension and predis are unavailable, the new line 137 throws an exception stating that \Predis\Client is not a class.