[DI] Clear service reference graph #25204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
di-graph-clear
branch
from
bfb4c45
to
2744b41
Compare
|
Is this to replace #25180 ? |
Simperfit
approved these changes
Nov 29, 2017
chalasr
approved these changes
Nov 29, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Clear service reference graph | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes (memory usage) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted while playing with the container: we keep this graph in memory even it its stale already. Clearing it also leave circular refs for the php garbage collector, better clean ourselves. Commits ------- 2744b41 [DI] Clear service reference graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while playing with the container: we keep this graph in memory even it its stale already.
Clearing it also leave circular refs for the php garbage collector, better clean ourselves.