Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Clear service reference graph #25204

Merged
merged 1 commit into from Nov 29, 2017

Conversation

@nicolas-grekas
Copy link
Member

commented Nov 29, 2017

Q A
Branch? 3.4
Bug fix? yes (memory usage)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Spotted while playing with the container: we keep this graph in memory even it its stale already.
Clearing it also leave circular refs for the php garbage collector, better clean ourselves.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-graph-clear branch from bfb4c45 to 2744b41 Nov 29, 2017

@sroze

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

Is this to replace #25180 ?

@nicolas-grekas nicolas-grekas merged commit 2744b41 into symfony:3.4 Nov 29, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Nov 29, 2017
bug #25204 [DI] Clear service reference graph (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Clear service reference graph

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes (memory usage)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Spotted while playing with the container: we keep this graph in memory even it its stale already.
Clearing it also leave circular refs for the php garbage collector, better clean ourselves.

Commits
-------

2744b41 [DI] Clear service reference graph

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-graph-clear branch Nov 29, 2017

This was referenced Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.