bug #25204 [DI] Clear service reference graph (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Clear service reference graph

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes (memory usage)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Spotted while playing with the container: we keep this graph in memory even it its stale already.
Clearing it also leave circular refs for the php garbage collector, better clean ourselves.

Commits
-------

2744b41 [DI] Clear service reference graph

src/Symfony/Component/DependencyInjection/Compiler/Compiler.php

@@ -159,6 +159,8 @@ public function compile(ContainerBuilder $container)
             }
 
             throw $e;
+        } finally {
+            $this->getServiceReferenceGraph()->clear();
         }
     }
 }

src/Symfony/Component/DependencyInjection/Compiler/ServiceReferenceGraph.php

@@ -75,6 +75,9 @@ public function getNodes()
      */
     public function clear()
     {
+        foreach ($this->nodes as $node) {
+            $node->clear();
+        }
         $this->nodes = array();
     }
 

src/Symfony/Component/DependencyInjection/Compiler/ServiceReferenceGraphNode.php

@@ -107,4 +107,12 @@ public function getValue()
     {
         return $this->value;
     }
+
+    /**
+     * Clears all edges.
+     */
+    public function clear()
+    {
+        $this->inEdges = $this->outEdges = array();
+    }
 }

src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php

@@ -142,6 +142,7 @@ public function dump(array $options = array())
             $currentPath = array($id => $id);
             $this->analyzeCircularReferences($node->getOutEdges(), $checkedNodes, $currentPath);
         }
+        $this->container->getCompiler()->getServiceReferenceGraph()->clear();
 
         $this->docStar = $options['debug'] ? '*' : '';