New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash #25308

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
5 participants
@Simperfit
Contributor

Simperfit commented Dec 4, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25193
License MIT
Doc PR none

You can see in the reproducer when running bin/console debug:container that there an error in the ouput (like in the issue) when using a class with \ in the service name.

This PR fix this wrong output. (even if that feels more developer thingy when there are xml everywhere ;)

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 4, 2017

Member

I'm removing the photo from the description, it's a bit weird to see your face when reviewing the PR :)
For which branch is the bug fix? This targets master right now, not sure it's correct.

Member

nicolas-grekas commented Dec 4, 2017

I'm removing the photo from the description, it's a bit weird to see your face when reviewing the PR :)
For which branch is the bug fix? This targets master right now, not sure it's correct.

@Simperfit Simperfit changed the base branch from master to 3.3 Dec 4, 2017

@Simperfit

This comment has been minimized.

Show comment
Hide comment
@Simperfit

Simperfit Dec 4, 2017

Contributor

@nicolas-grekas it's for 3.3 since the bug does not exist before.

Contributor

Simperfit commented Dec 4, 2017

@nicolas-grekas it's for 3.3 since the bug does not exist before.

@fabpot

fabpot approved these changes Dec 4, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 4, 2017

Member

Thank you @Simperfit.

Member

fabpot commented Dec 4, 2017

Thank you @Simperfit.

@fabpot fabpot merged commit 890edf7 into symfony:3.3 Dec 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 4, 2017

bug #25308 [FrameworkBundle] Fix a bug where a color tag will be show…
…n when passing an antislash (Simperfit)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25193
| License       | MIT
| Doc PR        | none

You can see in the [reproducer](Simperfit/symfony-reproducer@e6509ff) when running `bin/console debug:container` that there an error in the ouput (like in the issue) when using a class with `\` in the service name.

This PR fix this wrong output. (even if that feels more developer thingy when there are xml everywhere ;)

Commits
-------

890edf7 [FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash

This was referenced Dec 4, 2017

@Simperfit Simperfit deleted the Simperfit:bugfix/fix-a-bug-where-an-antislash-will-break-the-ouput branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment