[Form] Support \DateTimeImmutable #25582
Conversation
| throw new TransformationFailedException('Expected a \DateTimeImmutable.'); | ||
| } | ||
|
|
||
| return new \DateTime($value->format(\DateTime::RFC3339)); |
There was a problem hiding this comment.
Maybe use createFromFormat here to remove the need for PHP to guess the date format.
There was a problem hiding this comment.
@jvasseur , good idea, thanx.
| * | ||
| * @throws TransformationFailedException If the given value is not a \DateTimeImmutable | ||
| */ | ||
| public function transform($value): ?\DateTime |
There was a problem hiding this comment.
Adding the return type hint breaks the prototype.
| * | ||
| * @throws TransformationFailedException If the given value is not a \DateTime | ||
| */ | ||
| public function reverseTransform($value): ?\DateTimeImmutable |
There was a problem hiding this comment.
Adding the return type hint breaks the prototype.
|
Status: needs work |
|
Status: Needs Review |
|
Anything else needed here? |
vudaltsov
force-pushed
the
form-datetime-immutable
branch
from
73a5215
to
7721aed
Compare
|
Rebased. Added a changelog entry and replaced previously added If everything's good after this, I will squash commits. |
|
Thank you @vudaltsov. |
|
Are there plans to port this to at least Symfony 3.4? |
|
@ste93cry Since this is considered to be a new feature, it most likely won't land in 3.4, which is in bugfix-only mode. |
|
@ste93cry , during this week-end I will create a small bundle to add this functionality to earlier Symfony versions. |
…ateTimeType (vudaltsov) This PR was merged into the master branch. Discussion ---------- [Form] input=datetime_immutable for DateType, TimeType, DateTimeType Related to symfony/symfony#25582. Commits ------- f6bf5f2 Added input=datetime_immutable for DateType, TimeType, DateTimeType.
|
Created a polyfill bundle for those who want to use |
This PR implements
input=datetime_immutable. Replaces #25273.