[DependencyInjection] allow null values for root nodes in YAML configs #25891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 22, 2018
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25760 |
| License | MIT |
| Doc PR |
This was referenced Jan 22, 2018
|
awesome, thanks! |
fabpot
approved these changes
Jan 23, 2018
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 23, 2018
…YAML configs (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] allow null values for root nodes in YAML configs | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25760 | License | MIT | Doc PR | Commits ------- 52dd825 allow null values for root nodes in YAML configs
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
|
This PR caused a build failure at HttplugBundle. There is a test that tests for empty configuration. The following config will be treated as httplug:This is just an FYI in case this was missed in the review process. Im happy to rewrite the tests to if this was the intention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.