Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache][WebProfiler][3.4] fix collecting cache stats with sub-requests + allow clearing calls #26082

Merged
merged 1 commit into from
Feb 11, 2018

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Feb 7, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23820
License MIT
Doc PR -

This is a follow-up PR for #26080. It additionally adds the reset behavior for the TraceableAdapter back.

@dmaicher dmaicher changed the title [Cache][WebProfiler] fix collecting cache stats with sub-requests + allow clearing calls [Cache][WebProfiler][3.4] fix collecting cache stats with sub-requests + allow clearing calls Feb 7, 2018
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 7, 2018
@nicolas-grekas
Copy link
Member

Thank you @dmaicher.

@nicolas-grekas nicolas-grekas merged commit 132bba6 into symfony:3.4 Feb 11, 2018
nicolas-grekas added a commit that referenced this pull request Feb 11, 2018
…sub-requests + allow clearing calls (dmaicher)

This PR was merged into the 3.4 branch.

Discussion
----------

[Cache][WebProfiler][3.4] fix collecting cache stats with sub-requests + allow clearing calls

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23820
| License       | MIT
| Doc PR        | -

This is a follow-up PR for #26080. It additionally adds the reset behavior for the `TraceableAdapter` back.

Commits
-------

132bba6 [Cache][WebProfiler] fix collecting cache stats with sub-requests + allow clearing calls
This was referenced Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants