Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyInfo] added property list extractor by priority #26160

Closed
wants to merge 1 commit into from
Closed

[PropertyInfo] added property list extractor by priority #26160

wants to merge 1 commit into from

Conversation

andrey1s
Copy link

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

@dunglas
Copy link
Member

dunglas commented Feb 13, 2018

Can you give more information about your use case?

@andrey1s
Copy link
Author

I expect to get all the properties, but I can only get by priority extractor. Now I can define MergeExtractor (this PR in plans) and get properties all extractors.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Feb 14, 2018
@dunglas
Copy link
Member

dunglas commented Feb 19, 2018

What's the difference with the native behavior of the PropertyExtractor class? https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyInfo/PropertyInfoExtractor.php#L97

@andrey1s
Copy link
Author

can't use multiple sources, only the first successful. how about merge data from multiple sources?

@stof
Copy link
Member

stof commented Mar 26, 2018

your code still returns only the first one found, so there is no difference

@nicolas-grekas nicolas-grekas modified the milestones: 4.1, next Apr 20, 2018
@fabpot
Copy link
Member

fabpot commented Mar 31, 2019

Closing as there is no more activity here. @andrey1s Feel to reopen if you want to finish it.

@fabpot fabpot closed this Mar 31, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants