[Console] Fix tests #26489
Merged
[Console] Fix tests #26489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogizanagi my PR was done on 2.7 (as it was requested on the original issue by @Simperfit), all test were ok |
|
@noniagriconomie : Yes, no worries! You did nothing wrong. This indeed happened while changing the branch for merging your PR into master :) |
javiereguiluz
approved these changes
Mar 12, 2018
There was a problem hiding this comment.
Thanks Maxime! And @noniagriconomie, don't worry because this is not your fault at all. Changing the merging branch can make this happen, so no worries!
Simperfit
approved these changes
Mar 12, 2018
chalasr
approved these changes
Mar 12, 2018
|
Thanks @ogizanagi. |
chalasr
added a commit
that referenced
this pull request
Mar 12, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Fix tests | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Fix Console tests after #26439 merge. Commits ------- c429fa0 [Console] Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Console tests after #26439 merge.