Mark ExceptionInterfaces throwable #26702

ostrolucky · 2018-03-28T21:18:54Z

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

This interface is meant to be catched, but currently it doesn't guarantee class extending it is an instance of Throwable or Exception.

chalasr · 2018-03-29T08:30:36Z

Legit but breaks BC, not sure it's worth it (Symfony\Component\*\Exception\ExceptionInterface should be updated if we do it for this one)

ostrolucky · 2018-03-29T08:33:36Z

Not sure how it breaks BC?

I can update rest as well.

chalasr · 2018-03-29T08:36:07Z

It breaks for implementing classes that do not have the \Throwable api which exposes a bunch of methods

ostrolucky · 2018-03-29T08:50:48Z

Ah ok. Let's see if others see a way to move this forward. I'm for doing this in next minor version. Chance for BC break isn't high, this interface is meant to be used for exception classes.

nicolas-grekas · 2018-03-29T13:11:15Z

If we decide to do it, we should do it on all components, not only on one.
But I'm not sure this is worth it.

ostrolucky · 2018-03-29T13:30:44Z

Well benefit is not just theoretical safety of catching. This thing is going to be picked up by static analysis tools each time someone catches such exception, so user will need to suppress this for each of such case - pretty annoying.

Will change in all components if this change is approved.

unkind · 2018-03-29T18:01:30Z

This thing is going to be picked up by static analysis tools each time someone catches such exception

Why? It's perfectly fine to catch non-throwable.

fabpot · 2018-03-30T08:27:49Z

src/Symfony/Component/OptionsResolver/Exception/ExceptionInterface.php

@@ -16,6 +16,6 @@
 *
 * @author Bernhard Schussek <bschussek@gmail.com>
 */
-interface ExceptionInterface
+interface ExceptionInterface extends \Throwable


This interface, like the equivalent ones throughout the other components (about 20 of them), is meant to be a marker, nothing more.

So, I would not extend \Throwable here. But if we decide to do so, would it make sense to do it on all our markers?

This marker is for exceptions though, shouldn't it guarantee it's used on exception classes only?

How about deprecating this interface and replacing it another interface, extending Throwable?

Deprecating implies to find a name for the replacement in addition to bother our users, I don't think it's worth the hassle.

Regarding name, it could be {Component}ExceptionInterface. E.g. ConsoleExceptionInterface.

I think it makes sense to extend Throwable everywhere to semantically indicate that it is for exceptions. No need for deprecations as this should not break anything.

Ok at least somebody is with me, so I've applied this change in rest of the components as well.

ogizanagi · 2018-03-30T16:28:51Z

Two questions:

Are this interfaces really meant to be implemented on userland too anyway?

I get the point of having it for catching all exceptions of a given component, can be useful sometimes. But I don't think users are implementing their own (perhaps some librairies/bundles extending component capabilities, though).
Would it really be considered a BC break?

Anyway, even if it's only a marker interface, it's meant to be a marker interface for exceptions. So anyone implementing it on a non-exception class should be considered as misusing this interface and would not be considered a BC break, right?

ostrolucky · 2018-03-30T16:35:29Z

I have thought about that same way as you do. Maybe it would make sense to mark these @final as well? Not sure if it makes sense for interfaces, but we basically need to tell users "you are free to catch this interface in user-space / use instanceof, but not inherit it in your own classes".

fabpot · 2018-03-31T05:24:07Z

To answers the 2 questions:

No, this interface must not be implemented in userland
Extending another interface would not be a BC break

Simperfit · 2018-04-01T07:21:19Z

It make sense to me too.

xabbuh · 2018-04-01T19:27:34Z

I would agree on making this change in all components.

nicolas-grekas

I don't see any huge reason to do this change, but let's do it so that we won't discuss this again in another PR in the future... :)

fabpot · 2018-04-02T12:09:03Z

For the record, these interfaces did not extend anything as it was just a marker. All exception classes implementing this interface also extend a built-in PHP exception class (class FooException extends \RuntimeException implements ComponentException).

fabpot · 2018-04-03T05:07:46Z

Thank you @ostrolucky.

This PR was merged into the 4.1-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This interface is meant to be catched, but currently it doesn't guarantee class extending it is an instance of Throwable or Exception. Commits ------- b2d8792 Mark ExceptionInterfaces throwable

…(ostrolucky)" (nicolas-grekas) This PR was merged into the 4.1 branch. Discussion ---------- Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)" This reverts commit 9fda6d3, reversing changes made to ca53d3e. | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27419 | License | MIT | Doc PR | - #26702 introduced a BC break. Commits ------- 2ddb89b Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)"

nicolas-grekas · 2018-05-30T09:31:04Z

Reverted in #27420 as it broke BC, as spotted in #27419.

* 4.1: (22 commits) [HttpKernel] Fix restoring trusted proxies in tests Update UPGRADE-4.0.md [Messenger] Fix suggested enqueue adapter package bumped Symfony version to 4.1.1 updated VERSION for 4.1.0 updated CHANGELOG for 4.1.0 Insert correct parameter_bag service in AbstractController Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)" CODEOWNERS: some more rules removed unneeded comments in tests removed unneeded comments in tests Change PHPDoc in ResponseHeaderBag::getCookies() to help IDEs [HttpKernel] fix registering IDE links update UPGRADE-4.1 for feature #26332 Form field help option [HttpKernel] Set first trusted proxy as REMOTE_ADDR in InlineFragmentRenderer. [Process] Consider \"executable\" suffixes first on Windows Triggering RememberMe's loginFail() when token cannot be created bumped Symfony version to 4.1.0 updated VERSION for 4.1.0-BETA3 updated CHANGELOG for 4.1.0-BETA3 ...

dunglas · 2018-07-31T08:15:23Z

We'll be able to merge this patch again when phpspec/prophecy#412 will be merged and a new version of Prophecy will be tagged.

ciaranmcnulty · 2018-08-07T07:14:22Z

This is fixed in Prophecy 1.8

I haven't assessed impact on other test double libraries

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: #26702 #27420 #27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

…rolucky)" This reverts commit 9fda6d3, reversing changes made to ca53d3e.

* 4.1: (22 commits) [HttpKernel] Fix restoring trusted proxies in tests Update UPGRADE-4.0.md [Messenger] Fix suggested enqueue adapter package bumped Symfony version to 4.1.1 updated VERSION for 4.1.0 updated CHANGELOG for 4.1.0 Insert correct parameter_bag service in AbstractController Revert "feature symfony#26702 Mark ExceptionInterfaces throwable (ostrolucky)" CODEOWNERS: some more rules removed unneeded comments in tests removed unneeded comments in tests Change PHPDoc in ResponseHeaderBag::getCookies() to help IDEs [HttpKernel] fix registering IDE links update UPGRADE-4.1 for feature symfony#26332 Form field help option [HttpKernel] Set first trusted proxy as REMOTE_ADDR in InlineFragmentRenderer. [Process] Consider \"executable\" suffixes first on Windows Triggering RememberMe's loginFail() when token cannot be created bumped Symfony version to 4.1.0 updated VERSION for 4.1.0-BETA3 updated CHANGELOG for 4.1.0-BETA3 ...

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

@dunglas

This PR was merged into the 4.2-dev branch. Discussion ---------- Mark ExceptionInterfaces throwable #2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again. References: symfony/symfony#26702 symfony/symfony#27420 symfony/symfony#27419 phpspec/prophecy#412 ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes Commits ------- 17c3675226 Mark ExceptionInterfaces throwable

chalasr added this to the 4.1 milestone Mar 29, 2018

fabpot reviewed Mar 30, 2018

View reviewed changes

javiereguiluz added Bug OptionsResolver labels Mar 30, 2018

ostrolucky force-pushed the patch-18 branch from 71263d4 to f2ba290 Compare March 30, 2018 15:56

ostrolucky changed the title ~~[OptionsResolver] Mark ExceptionInterface throwable~~ Mark ExceptionInterfaces throwable Mar 30, 2018

Mark ExceptionInterfaces throwable

b2d8792

ostrolucky force-pushed the patch-18 branch from f2ba290 to b2d8792 Compare March 30, 2018 15:58

nicolas-grekas approved these changes Apr 2, 2018

View reviewed changes

carsonbot added the Status: Reviewed label Apr 2, 2018

xabbuh approved these changes Apr 2, 2018

View reviewed changes

Tobion approved these changes Apr 2, 2018

View reviewed changes

lyrixx approved these changes Apr 2, 2018

View reviewed changes

fabpot approved these changes Apr 3, 2018

View reviewed changes

fabpot merged commit b2d8792 into symfony:master Apr 3, 2018

nicolas-grekas mentioned this pull request May 30, 2018

Revert "feature #26702 Mark ExceptionInterfaces throwable (ostrolucky)" #27420

Merged

fabpot mentioned this pull request May 30, 2018

Release v4.1.0 #27424

Merged

dkarlovi mentioned this pull request Jul 31, 2018

Allow to double Throwable, or an interface that extends Throwable phpspec/prophecy#412

Merged

ostrolucky mentioned this pull request Aug 29, 2018

Mark ExceptionInterfaces throwable #2 #28307

Merged

sandergo90 pushed a commit to sandergo90/symfony that referenced this pull request Jul 4, 2019

Revert "feature symfony#26702 Mark ExceptionInterfaces throwable (ost…

db427d7

…rolucky)" This reverts commit 9fda6d3, reversing changes made to ca53d3e.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark ExceptionInterfaces throwable #26702

Mark ExceptionInterfaces throwable #26702

ostrolucky commented Mar 28, 2018 •

edited

Loading

chalasr commented Mar 29, 2018 •

edited

Loading

ostrolucky commented Mar 29, 2018

chalasr commented Mar 29, 2018

ostrolucky commented Mar 29, 2018

nicolas-grekas commented Mar 29, 2018

ostrolucky commented Mar 29, 2018

unkind commented Mar 29, 2018

fabpot Mar 30, 2018

ostrolucky Mar 30, 2018 •

edited

Loading

chalasr Mar 30, 2018

ostrolucky Mar 30, 2018

Tobion Mar 30, 2018

ostrolucky Mar 30, 2018

ogizanagi commented Mar 30, 2018

ostrolucky commented Mar 30, 2018

fabpot commented Mar 31, 2018

Simperfit commented Apr 1, 2018

xabbuh commented Apr 1, 2018

nicolas-grekas left a comment •

edited

Loading

fabpot commented Apr 2, 2018

fabpot commented Apr 3, 2018

nicolas-grekas commented May 30, 2018

dunglas commented Jul 31, 2018

ciaranmcnulty commented Aug 7, 2018

Mark ExceptionInterfaces throwable #26702

Mark ExceptionInterfaces throwable #26702

Conversation

ostrolucky commented Mar 28, 2018 • edited Loading

chalasr commented Mar 29, 2018 • edited Loading

ostrolucky commented Mar 29, 2018

chalasr commented Mar 29, 2018

ostrolucky commented Mar 29, 2018

nicolas-grekas commented Mar 29, 2018

ostrolucky commented Mar 29, 2018

unkind commented Mar 29, 2018

fabpot Mar 30, 2018

Choose a reason for hiding this comment

ostrolucky Mar 30, 2018 • edited Loading

Choose a reason for hiding this comment

chalasr Mar 30, 2018

Choose a reason for hiding this comment

ostrolucky Mar 30, 2018

Choose a reason for hiding this comment

Tobion Mar 30, 2018

Choose a reason for hiding this comment

ostrolucky Mar 30, 2018

Choose a reason for hiding this comment

ogizanagi commented Mar 30, 2018

ostrolucky commented Mar 30, 2018

fabpot commented Mar 31, 2018

Simperfit commented Apr 1, 2018

xabbuh commented Apr 1, 2018

nicolas-grekas left a comment • edited Loading

Choose a reason for hiding this comment

fabpot commented Apr 2, 2018

fabpot commented Apr 3, 2018

nicolas-grekas commented May 30, 2018

dunglas commented Jul 31, 2018

ciaranmcnulty commented Aug 7, 2018

ostrolucky commented Mar 28, 2018 •

edited

Loading

chalasr commented Mar 29, 2018 •

edited

Loading

ostrolucky Mar 30, 2018 •

edited

Loading

nicolas-grekas left a comment •

edited

Loading