Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misprint. #2

Closed
wants to merge 1 commit into from
Closed

Fix misprint. #2

wants to merge 1 commit into from

Conversation

Aliance
Copy link
Contributor

@Aliance Aliance commented Apr 24, 2017

No description provided.

@fabpot
Copy link
Member

fabpot commented Apr 26, 2017

This is a read-only repository, so we cannot merge this PR. Can you "move" it to symfony/symfony instead? Thanks.

@Aliance
Copy link
Contributor Author

Aliance commented Apr 26, 2017

Ok, I'll do it tomorrow.

@Aliance Aliance closed this Apr 26, 2017
@Aliance Aliance deleted the patch-1 branch April 27, 2017 07:43
stof added a commit to symfony/symfony that referenced this pull request Apr 27, 2017
This PR was merged into the 3.3-dev branch.

Discussion
----------

Fix misprint.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | –
| Fixed tickets | –
| License       | MIT
| Doc PR        | –

Copied from symfony/dotenv#2

Commits
-------

2fa1628 Fix misprint.
symfony-splitter pushed a commit that referenced this pull request Sep 4, 2018
This PR was merged into the 4.2-dev branch.

Discussion
----------

Mark ExceptionInterfaces throwable #2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again.

References:
symfony/symfony#26702
symfony/symfony#27420
symfony/symfony#27419
phpspec/prophecy#412

ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes

Commits
-------

17c3675226 Mark ExceptionInterfaces throwable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants