[Form] Fixed textarea_widget (W3C standards) #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hlecorche: Thanks for your work on this issue. Can you update the unit tests to be sure that this case is covered? If you're not comfortable with this, just tell me and I will do it myself |
|
@fabpot: I did'nt commited because I am not sure. I changed the "tests/Symfony/Tests/Component/Form/AbstractLayoutTest.php" file : Is it correct? |
fabpot
added a commit
that referenced
this pull request
Nov 22, 2011
Commits ------- 78e9b2f [Form] Fixed textarea_widget (W3C standards) Discussion ---------- [Form] Fixed textarea_widget (W3C standards) Textarea widget included the "pattern" attribute but is not valid by W3C standards. (See PR 2666 - New PR because rebase inside the 2.0 branch) --------------------------------------------------------------------------- by fabpot at 2011/11/18 09:01:41 -0800 @hlecorche: Thanks for your work on this issue. Can you update the unit tests to be sure that this case is covered? If you're not comfortable with this, just tell me and I will do it myself --------------------------------------------------------------------------- by hlecorche at 2011/11/19 02:51:06 -0800 @fabpot: I did'nt commited because I am not sure. I changed the "tests/Symfony/Tests/Component/Form/AbstractLayoutTest.php" file : public function testTextarea() { $form = $this->factory->createNamed('textarea', 'na&me', 'foo&bar', array( 'property_path' => 'name', 'pattern' => 'foo', )); $this->assertWidgetMatchesXpath($form->createView(), array(), '/textarea [@name="na&me"] [not(@pattern)] [.="foo&bar"] ' ); } Is it correct?
|
@hlecorche: perfect. I've added the test here: 38f64a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textarea widget included the "pattern" attribute but is not valid by W3C standards.
(See PR 2666 - New PR because rebase inside the 2.0 branch)