New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix bad exception on uninitialized references to non-shared services #27364

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented May 24, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27360
License MIT
Doc PR -

This restriction is unneeded complexity that prevents legit use cases (see linked issue #27360).

@stof

stof approved these changes May 24, 2018

@curry684

This comment has been minimized.

Contributor

curry684 commented May 24, 2018

Seems fine to me 👍 I'll rerun the offending tests to confirm when it's merged.

@nicolas-grekas nicolas-grekas merged commit 8bba68f into symfony:3.4 May 25, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 25, 2018

bug #27364 [DI] Fix bad exception on uninitialized references to non-…
…shared services (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix bad exception on uninitialized references to non-shared services

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27360
| License       | MIT
| Doc PR        | -

This restriction is unneeded complexity that prevents legit use cases (see linked issue #27360).

Commits
-------

8bba68f [DI] Fix bad exception on uninitialized references to non-shared services

This was referenced May 25, 2018

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fwb-non-shared-private branch May 25, 2018

@fabpot fabpot referenced this pull request May 26, 2018

Merged

Release v4.1.0-BETA3 #27390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment