[DI] Fix bad exception on uninitialized references to non-shared services #27364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
May 24, 2018
nicolas-grekas
force-pushed
the
fwb-non-shared-private
branch
from
c6bdc5a
to
8bba68f
Compare
chalasr
approved these changes
May 24, 2018
|
Seems fine to me 👍 I'll rerun the offending tests to confirm when it's merged. |
ogizanagi
approved these changes
May 24, 2018
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2018
…shared services (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix bad exception on uninitialized references to non-shared services | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27360 | License | MIT | Doc PR | - This restriction is unneeded complexity that prevents legit use cases (see linked issue #27360). Commits ------- 8bba68f [DI] Fix bad exception on uninitialized references to non-shared services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restriction is unneeded complexity that prevents legit use cases (see linked issue #27360).