[HttpKernel] Turn HTTP exceptions to responses on terminateWithException() #27505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 5, 2018
| @@ -49,6 +49,15 @@ public function __construct($controller, LoggerInterface $logger = null, $debug | |||
|
|
|||
| public function onKernelException(GetResponseForExceptionEvent $event) | |||
| { | |||
| while (null === $this->controller) { | |||
There was a problem hiding this comment.
should be a if rather than a while. It would be much easier to understand, and it can never loop anyway.
There was a problem hiding this comment.
using while allows using the break below :)
There was a problem hiding this comment.
while removed btw :)
nicolas-grekas
force-pushed
the
kernel-http-x
branch
2 times, most recently
from
b9b3a8f
to
76d532e
Compare
fabpot
reviewed
Jun 6, 2018
| @@ -49,6 +49,19 @@ public function __construct($controller, LoggerInterface $logger = null, $debug | |||
|
|
|||
| public function onKernelException(GetResponseForExceptionEvent $event) | |||
| { | |||
| if (null === $this->controller) { | |||
| $terminating = false; | |||
| foreach (debug_backtrace() as $frame) { | |||
There was a problem hiding this comment.
I'm very much against this kind of code.
There was a problem hiding this comment.
I agree, I lacked a better idea, but this is fixed now.
nicolas-grekas
force-pushed
the
kernel-http-x
branch
from
76d532e
to
d5c882f
Compare
|
Let's revert instead, see #27516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26138 introduced a BC break that is described in the linked issue.
In order to fix it, I propose to postpone generating a response for HTTP exceptions to the exception event that is throw in
terminateWithException(). This allows providing the target DX (generate 404 forNotFoundHttpException) while allowing ppl that have custom listeners or try/catch to keep things working as previously.