[TwigBundle][DX] Only add the Twig WebLinkExtension if the WebLink component is enabled #27626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
TwigBundle
DX
nicolas-grekas
approved these changes
Jun 19, 2018
stof
reviewed
Jun 19, 2018
| @@ -71,6 +72,10 @@ public static function onUndefinedFunction($name) | |||
| return false; | |||
| } | |||
|
|
|||
| if (\class_exists(FullStack::class) && 'web-link' === self::$functionComponents[$name]) { | |||
There was a problem hiding this comment.
what about other components needing to be enabled ?
There was a problem hiding this comment.
For the other functions/filters?
There was a problem hiding this comment.
yeah, you add a special error message for the full stack case here when forgetting to enable a component (while the previous error message was for the non-fullstack case to tell to install a package). But web-link is not the only component needing to be enabled explicitly in a fullstack project. If we start to handled this case with nicer error messages, we should do it for all components, not only for one.
thewilkybarkid
commented
Jun 20, 2018
| 'security-core' => 'add the "SecurityBundle"', | ||
| 'security-http' => 'add the "SecurityBundle"', | ||
| 'web-link' => 'enable "framework.web_link"', | ||
| 'workflow' => 'enable "framework.workflows"', |
There was a problem hiding this comment.
I think these are right, and the only ones effected.
fabpot
approved these changes
Jun 25, 2018
…mponent is enabled
|
Thank you @thewilkybarkid. |
fabpot
added a commit
that referenced
this pull request
Jun 25, 2018
… WebLink component is enabled (thewilkybarkid) This PR was squashed before being merged into the 3.4 branch (closes #27626). Discussion ---------- [TwigBundle][DX] Only add the Twig WebLinkExtension if the WebLink component is enabled | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While adding elifesciences/journal#990 I was a bit confused why the `preload()` Twig function didn't work initially. Turns out the WebLink component is disabled by default if using the full stack, but the Twig extension is always enabled. This only adds the Twig extension if the component is enabled, and shows a friendly error message if it's not. Commits ------- cccb66f [TwigBundle][DX] Only add the Twig WebLinkExtension if the WebLink component is enabled
This was referenced Jun 25, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding elifesciences/journal#990 I was a bit confused why the
preload()Twig function didn't work initially. Turns out the WebLink component is disabled by default if using the full stack, but the Twig extension is always enabled.This only adds the Twig extension if the component is enabled, and shows a friendly error message if it's not.