[Yaml] Fixed invalid Parser behavior #27898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
previously requested changes
Jul 12, 2018
stof
previously requested changes
Jul 12, 2018
xabbuh
reviewed
Jul 12, 2018
xabbuh
reviewed
Jul 13, 2018
|
@xabbuh Can you review this one one more time please? |
|
As this introduce a new deprecation, it should go in master, not in 4.1. We don't introduce deprecations in patch releases. |
|
Hello, I missed your message. I'll rebase shortly. |
guiguiboy
force-pushed
the
ticket_27874
branch
from
8d85944
to
d95792d
Compare
|
@guiguiboy I will look into the changes in more depth shortly. Thanks so far. 👍 Can you in the meantime please document the deprecation in the upgrade files and in the changelog file of the Yaml component? |
guiguiboy
force-pushed
the
ticket_27874
branch
from
d95792d
to
069fa71
Compare
|
I updated the files supposing it will go in version 5.0.0. If required, I can change back to 4.2.0. |
xabbuh
requested changes
Dec 17, 2018
guiguiboy
force-pushed
the
ticket_27874
branch
2 times, most recently
from
069fa71
to
532cce8
Compare
xabbuh
approved these changes
Dec 30, 2018
guiguiboy
force-pushed
the
ticket_27874
branch
from
458bf0b
to
b11e522
Compare
guiguiboy
force-pushed
the
ticket_27874
branch
from
f87315f
to
b190d9f
Compare
guiguiboy
force-pushed
the
ticket_27874
branch
from
b190d9f
to
7bf8381
Compare
xabbuh
dismissed stale reviews from stof and fabpot
changes have been addressed
|
Thank you @guiguiboy. |
xabbuh
added a commit
that referenced
this pull request
Feb 6, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Yaml] Fixed invalid Parser behavior | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27874 | License | MIT | Doc PR | NA This fixes #27874 I'm not sure about the update in composer.json though. It seems a good idea because I was able to run composer update without the zip extension. If required, I'll remove it. Commits ------- 7bf8381 Added deprecation notice when mapping keys are found in multi-line blocks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #27874
I'm not sure about the update in composer.json though. It seems a good idea because I was able to run composer update without the zip extension. If required, I'll remove it.