Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] Fixed invalid Parser behavior #27898

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
7 participants
@guiguiboy
Copy link
Contributor

commented Jul 8, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27874
License MIT
Doc PR NA

This fixes #27874
I'm not sure about the update in composer.json though. It seems a good idea because I was able to run composer update without the zip extension. If required, I'll remove it.

@fabpot
Copy link
Member

left a comment

/cc @xabbuh

Show resolved Hide resolved composer.json Outdated

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from 7ed6318 to 1027180 Jul 13, 2018

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from 3c6a833 to 8d85944 Jul 19, 2018

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Jul 23, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

@xabbuh Can you review this one one more time please?

@stof

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

As this introduce a new deprecation, it should go in master, not in 4.1. We don't introduce deprecations in patch releases.

@guiguiboy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2018

Hello, I missed your message. I'll rebase shortly.

@guiguiboy guiguiboy changed the base branch from 4.1 to master Oct 2, 2018

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from 8d85944 to d95792d Oct 2, 2018

@xabbuh

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

@guiguiboy I will look into the changes in more depth shortly. Thanks so far. 👍 Can you in the meantime please document the deprecation in the upgrade files and in the changelog file of the Yaml component?

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from d95792d to 069fa71 Oct 13, 2018

@guiguiboy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2018

I updated the files supposing it will go in version 5.0.0. If required, I can change back to 4.2.0.

@chalasr chalasr modified the milestones: 4.1, next Nov 1, 2018

Show resolved Hide resolved src/Symfony/Component/Yaml/Parser.php Outdated
Show resolved Hide resolved src/Symfony/Component/Yaml/Parser.php Outdated
Show resolved Hide resolved UPGRADE-5.0.md Outdated
Show resolved Hide resolved src/Symfony/Component/Yaml/CHANGELOG.md Outdated
Show resolved Hide resolved src/Symfony/Component/Yaml/CHANGELOG.md Outdated

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch 2 times, most recently from 069fa71 to 532cce8 Dec 28, 2018

@xabbuh

xabbuh approved these changes Dec 30, 2018

Copy link
Member

left a comment

with a minor tweak to the deprecation message

Show resolved Hide resolved src/Symfony/Component/Yaml/Parser.php Outdated

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from 458bf0b to b11e522 Jan 5, 2019

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from f87315f to b190d9f Jan 25, 2019

@guiguiboy guiguiboy force-pushed the guiguiboy:ticket_27874 branch from b190d9f to 7bf8381 Jan 25, 2019

@xabbuh xabbuh dismissed stale reviews from stof and fabpot Feb 6, 2019

changes have been addressed

@xabbuh

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Thank you @guiguiboy.

@xabbuh xabbuh merged commit 7bf8381 into symfony:master Feb 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

xabbuh added a commit that referenced this pull request Feb 6, 2019

feature #27898 [Yaml] Fixed invalid Parser behavior (guiguiboy)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Yaml] Fixed invalid Parser behavior

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27874
| License       | MIT
| Doc PR        | NA

This fixes #27874
I'm not sure about the update in composer.json though. It seems a good idea because I was able to run composer update without the zip extension. If required, I'll remove it.

Commits
-------

7bf8381 Added deprecation notice when mapping keys are found in multi-line blocks

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.