[DI] Trigger exception when using '@id' name in parent option #28315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM on master on my side. |
ro0NL
approved these changes
Aug 31, 2018
fabpot
approved these changes
Sep 4, 2018
|
Thank you @Seb33300. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
… option (Seb33300) This PR was squashed before being merged into the 4.2-dev branch (closes #28315). Discussion ---------- [DI] Trigger exception when using '@id' name in parent option Same exception [already triggered](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php#L505) on the `decorates` option. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Note sure if I should submit this change for master or previous branches... Commits ------- 1f67db6 [DI] Trigger exception when using '@id' name in parent option
stof
added
the
DX
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same exception already triggered on the
decoratesoption.Note sure if I should submit this change for master or previous branches...