Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface #29090

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
7 participants
@desmax
Copy link
Contributor

commented Nov 5, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29089
License MIT

While autowiring Translator using Symfony\Contracts\Translation\TranslatorInterface symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface.

@xabbuh

xabbuh approved these changes Nov 5, 2018

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 5, 2018

@stof

stof approved these changes Nov 5, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

Thank you @desmax.

@nicolas-grekas nicolas-grekas merged commit 65f321f into symfony:master Nov 6, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 6, 2018

bug #29090 LoggingTranslator should implement Symfony\Contracts\Trans…
…lation\TranslatorInterface (desmax)

This PR was merged into the 4.2-dev branch.

Discussion
----------

LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29089
| License       | MIT

While autowiring Translator using `Symfony\Contracts\Translation\TranslatorInterface` symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface.

Commits
-------

65f321f LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.