New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add samesite attribute to session cookie after session migration #29094

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@rpkamp
Contributor

rpkamp commented Nov 5, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29092
License MIT
Doc PR N/A

@rpkamp rpkamp force-pushed the rpkamp:samesite-session-regenerate branch from 7d7316a to df90300 Nov 5, 2018

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 6, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 6, 2018

Thank you @rpkamp.

@nicolas-grekas nicolas-grekas merged commit df90300 into symfony:master Nov 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 6, 2018

bug #29094 Add samesite attribute to session cookie after session mig…
…ration (rpkamp)

This PR was merged into the 4.2-dev branch.

Discussion
----------

Add samesite attribute to session cookie after session migration

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29092
| License       | MIT
| Doc PR        | N/A

Commits
-------

df90300 Add samesite attribute to session cookie after session migration

@rpkamp rpkamp deleted the rpkamp:samesite-session-regenerate branch Nov 6, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment