New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Fixed keeping hash of equal \DateTimeInterface on submit #29185

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
5 participants
@HeahDude
Member

HeahDude commented Nov 12, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@HeahDude HeahDude changed the base branch from master to 2.8 Nov 12, 2018

@HeahDude HeahDude force-pushed the HeahDude:fix-date-by-reference branch from 6adbd7c to fafefb1 Nov 12, 2018

@xabbuh

xabbuh approved these changes Nov 12, 2018

@HeahDude HeahDude force-pushed the HeahDude:fix-date-by-reference branch from fafefb1 to bc2e2cb Nov 12, 2018

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Nov 13, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 13, 2018

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit bc2e2cb into symfony:2.8 Nov 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 13, 2018

bug #29185 [Form] Fixed keeping hash of equal \DateTimeInterface on s…
…ubmit (HeahDude)

This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Fixed keeping hash of equal \DateTimeInterface on submit

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

bc2e2cb [Form] Fixed keeping hash of equal \DateTimeInterface on submit

@HeahDude HeahDude deleted the HeahDude:fix-date-by-reference branch Nov 13, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

This was referenced Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment