[TwigBundle] Sync tab navigation css #29421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 2, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 2, 2018
This PR was merged into the 4.2 branch. Discussion ---------- [TwigBundle] Sync tab navigation css | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> The exception panel in the profiler loads the css from the twig bundle, and is effectively overriding the profiler css. This solves tab navigation. Which got broken due dark theming. Before (hovered 2nd tab)  After  Commits ------- d6704bb [TwigBundle] Sync tab navigation css
|
have you checked the exception page after these changes ? I'm not sure they define the theming variables, and your CSS does not define a fallback style without the variable. |
|
@stof i did yes :) i've already merged the css variables (light variant) to twig-bundle, so all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception panel in the profiler loads the css from the twig bundle, and is effectively overriding the profiler css.
This solves tab navigation. Which got broken due dark theming.
Before (hovered 2nd tab)
After