New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBundle] Sync tab navigation css #29421

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
4 participants
@ro0NL
Contributor

ro0NL commented Dec 2, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

The exception panel in the profiler loads the css from the twig bundle, and is effectively overriding the profiler css.

This solves tab navigation. Which got broken due dark theming.

Before (hovered 2nd tab)

image

After

image

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 2, 2018

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit d6704bb into symfony:4.2 Dec 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 2, 2018

minor #29421 [TwigBundle] Sync tab navigation css (ro0NL)
This PR was merged into the 4.2 branch.

Discussion
----------

[TwigBundle] Sync tab navigation css

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

The exception panel in the profiler loads the css from the twig bundle, and is effectively overriding the profiler css.

This solves tab navigation. Which got broken due dark theming.

Before (hovered 2nd tab)

![image](https://user-images.githubusercontent.com/1047696/49338850-fc309580-f627-11e8-9c15-4e6ffee48b0c.png)

After

![image](https://user-images.githubusercontent.com/1047696/49338828-cf7c7e00-f627-11e8-95a5-6dada5fac319.png)

Commits
-------

d6704bb [TwigBundle] Sync tab navigation css

@ro0NL ro0NL deleted the ro0NL:exception-tabs branch Dec 3, 2018

@stof

This comment has been minimized.

Member

stof commented Dec 3, 2018

have you checked the exception page after these changes ? I'm not sure they define the theming variables, and your CSS does not define a fallback style without the variable.

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Dec 3, 2018

@stof i did yes :) i've already merged the css variables (light variant) to twig-bundle, so all good 👍

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment