Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPUnit bridge] Bump php version of PHPUnit-bridge #29718

Merged
merged 1 commit into from Jan 1, 2019

Conversation

Projects
None yet
5 participants
@gmponos
Copy link
Contributor

commented Dec 28, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no (?)
Deprecations? no
Tests pass? yes
License MIT

Related to #29623 (comment)

I checked the BC page I think I couldn't find any related to BC changes... anyway...

As far as I understood from the comment above I must target master branch.

@gmponos gmponos changed the title Bump php version of PHPUnit-bridge [PHPUnit bridge] Bump php version of PHPUnit-bridge Dec 28, 2018

@nicolas-grekas
Copy link
Member

left a comment

while bumping to phpunit5 & php5.5, there are many opportunities to improve the code (eg $this in closure, and polyfills that we could remove, see "Legacy" namespace.)
Up to do it?

Show resolved Hide resolved src/Symfony/Bridge/PhpUnit/bin/simple-phpunit Outdated
@gmponos

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

while bumping to phpunit5

haven't bumped PHPUnit version..

there are many opportunities to improve the code (eg $this in closure, and polyfills that we could remove, see "Legacy" namespace

it's not that I don't want to help.. but I am not sure about which changes and what you are thinking exactly.. so we might have a lot going back and forth discussion.. I suggest to have these changes on other PRs..

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

phpunit 5 is for php56 😞

I suggest to have these changes on other PRs..

works for me!

@@ -5,6 +5,7 @@ CHANGELOG
-----

* added `ClassExistsMock`
* bumped PHP version from 5.5.3 to 5.5.9

This comment has been minimized.

Copy link
@fabpot

fabpot Dec 29, 2018

Member

Is it a typo? 5.3.3?

This comment has been minimized.

Copy link
@gmponos

gmponos Dec 29, 2018

Author Contributor

🤦‍♂️... Yes it is a type.. fixed.

@greg0ire greg0ire referenced this pull request Dec 29, 2018

Merged

[PhpUnitBridge] Url encoded deprecations helper config #29211

7 of 7 tasks complete
@greg0ire

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2018

The Legacy namespace should stay around for a while, but some simplifications seem indeed possible: https://3v4l.org/MmG7J I'm working on a PR right now.

@fabpot

fabpot approved these changes Jan 1, 2019

@fabpot fabpot force-pushed the gmponos:bump_php_version_phpunit_bridge branch from e4f7a09 to 5931309 Jan 1, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jan 1, 2019

Thank you @gmponos.

@fabpot fabpot merged commit 5931309 into symfony:master Jan 1, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 1, 2019

feature #29718 [PHPUnit bridge] Bump php version of PHPUnit-bridge (g…
…mponos)

This PR was squashed before being merged into the 4.3-dev branch (closes #29718).

Discussion
----------

[PHPUnit bridge] Bump php version of PHPUnit-bridge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no (?)
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Related to #29623 (comment)

I checked the BC page I think I couldn't find any related to BC changes... anyway...

As far as I understood from the comment above I must target `master` branch.

Commits
-------

5931309 [PHPUnit bridge] Bump php version of PHPUnit-bridge

@gmponos gmponos deleted the gmponos:bump_php_version_phpunit_bridge branch Jan 1, 2019

nicolas-grekas added a commit that referenced this pull request Jan 27, 2019

minor #29724 [PHPUnitBridge] Static access in closure (greg0ire, nico…
…las-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[PHPUnitBridge] Static access in closure

| Q             | A
| ------------- | ---
| Branch?       | master for features
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n / a
| License       | MIT
| Doc PR        | n / a

#29718 bumps php to 5.5 . This is what we could simplify if it gets merged, thanks to this "new" PHP feature: https://3v4l.org/sJOWr

EDIT: it was merged, this can be reviewed.

Commits
-------

97f3023 Use the scope of an instance
9df76eb Extract closures into static functions

fabpot added a commit that referenced this pull request Apr 12, 2019

feature #29211 [PhpUnitBridge] Url encoded deprecations helper config…
… (greg0ire)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[PhpUnitBridge] Url encoded deprecations helper config

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #28048
| License       | MIT
| Doc PR        | symfony/symfony-docs#10701

First stab at implementing a new way of configuring the deprecation error handler. Includes a refactoring to keep things manageable.

Rework of #24867, blocked by #29718

TODO:

- [x] make the code 5.5 compatible 😢
- [x] add more tests
- [x] deprecate modes (using echo :P)
- [x] test this on real life projects and add some screenshots
- [x] docs PR
- [x] handle `strict`
- [x] adapt existing CI config

# Quiet configuration

![quiet](https://user-images.githubusercontent.com/657779/49341318-fa78c900-f64b-11e8-9504-a8a9eac4baf8.png)

# Default configuration

![verbose](https://user-images.githubusercontent.com/657779/49341322-10868980-f64c-11e8-9d90-dc3f6a18c335.png)

Commits
-------

1c73f9c [PhpUnitBridge] Url encoded deprecations helper config

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.