[PHPUnit bridge] Bump php version of PHPUnit-bridge #29718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmponos
changed the title
haven't bumped PHPUnit version..
it's not that I don't want to help.. but I am not sure about which changes and what you are thinking exactly.. so we might have a lot going back and forth discussion.. I suggest to have these changes on other PRs.. |
|
phpunit 5 is for php56 😞
works for me! |
nicolas-grekas
approved these changes
Dec 28, 2018
carsonbot
added
Status: Reviewed
Status: Needs Work
and removed
Status: Needs Review
Status: Reviewed
labels
fabpot
requested changes
Dec 29, 2018
| @@ -5,6 +5,7 @@ CHANGELOG | |||
| ----- | |||
|
|
|||
| * added `ClassExistsMock` | |||
| * bumped PHP version from 5.5.3 to 5.5.9 | |||
There was a problem hiding this comment.
🤦♂️... Yes it is a type.. fixed.
7 tasks
|
The |
fabpot
approved these changes
Jan 1, 2019
fabpot
force-pushed
the
bump_php_version_phpunit_bridge
branch
from
e4f7a09
to
5931309
Compare
|
Thank you @gmponos. |
fabpot
added a commit
that referenced
this pull request
Jan 1, 2019
…mponos) This PR was squashed before being merged into the 4.3-dev branch (closes #29718). Discussion ---------- [PHPUnit bridge] Bump php version of PHPUnit-bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no (?) | Deprecations? | no | Tests pass? | yes | License | MIT Related to #29623 (comment) I checked the BC page I think I couldn't find any related to BC changes... anyway... As far as I understood from the comment above I must target `master` branch. Commits ------- 5931309 [PHPUnit bridge] Bump php version of PHPUnit-bridge
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2019
…las-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [PHPUnitBridge] Static access in closure | Q | A | ------------- | --- | Branch? | master for features | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n / a | License | MIT | Doc PR | n / a #29718 bumps php to 5.5 . This is what we could simplify if it gets merged, thanks to this "new" PHP feature: https://3v4l.org/sJOWr EDIT: it was merged, this can be reviewed. Commits ------- 97f3023 Use the scope of an instance 9df76eb Extract closures into static functions
fabpot
added a commit
that referenced
this pull request
Apr 12, 2019
… (greg0ire) This PR was merged into the 4.3-dev branch. Discussion ---------- [PhpUnitBridge] Url encoded deprecations helper config | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #28048 | License | MIT | Doc PR | symfony/symfony-docs#10701 First stab at implementing a new way of configuring the deprecation error handler. Includes a refactoring to keep things manageable. Rework of #24867, blocked by #29718 TODO: - [x] make the code 5.5 compatible 😢 - [x] add more tests - [x] deprecate modes (using echo :P) - [x] test this on real life projects and add some screenshots - [x] docs PR - [x] handle `strict` - [x] adapt existing CI config # Quiet configuration  # Default configuration  Commits ------- 1c73f9c [PhpUnitBridge] Url encoded deprecations helper config
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #29623 (comment)
I checked the BC page I think I couldn't find any related to BC changes... anyway...
As far as I understood from the comment above I must target
masterbranch.