Debug finalized config in debug:config #30648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
deps=high should pass after merge. |
fabpot
approved these changes
Mar 23, 2019
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2019
This PR was merged into the 4.2 branch. Discussion ---------- Debug finalized config in debug:config | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #30637 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Re-processing the extension config in `debug:config` causes a lot of steps to be ignored, basically everything in `ValidateEnvPlaceholdersPass`. As such we trigger a misleading error when this command is invoked. Commits ------- b9ac3a5 Debug finalized config in debug:config
Merged
fabpot
added a commit
that referenced
this pull request
Aug 26, 2021
…bug:config and consistently resolve parameter values (herndlm) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Fall back to default configuration in debug:config and consistently resolve parameter values | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #41121 | License | MIT | Doc PR | n/a Brings back determining the default configuration from pull request #30648. Refactors determining the extension config into a helper method to keep cognitive load low with early exits instead of nested ifs. Additionaly, while reviewing, we noticed that entries with parameters are not resolved correctly if they come from the default config and an application config is existing but they are not overriden. E.g. the session config for the framework would output `save_path: %kernel.cache_dir%/sessions` instead of the resolved value. Tested via unit test (obviously) and by manually removing bundle configuration in a Symfony project. Beware that I do not know much about bundles and internals, I looked that up while implementing this and might have missed better/simpler solutions or edge cases. Please somebody also do another functional test to ensure this is really working as it should. Commits ------- 9b6110b [FrameworkBundle] Fall back to default configuration in debug:config and consistently resolve parameter values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-processing the extension config in
debug:configcauses a lot of steps to be ignored, basically everything inValidateEnvPlaceholdersPass.As such we trigger a misleading error when this command is invoked.