Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr #31102

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@AngelFQC
Copy link

AngelFQC commented Apr 13, 2019

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ...
License MIT
Doc PR ...

Bootstrap provides a way to translate the “Browse” text in HTML with the data-browse attribute which can be added to the custom input label.

https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-html

But currently the attributes declared in label_attr aren't being added.

@nicolas-grekas
Copy link
Member

nicolas-grekas left a comment

(for 4.2?)

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Apr 14, 2019

@nicolas-grekas nicolas-grekas changed the title BS4 File layout: Allow set label attributes declared in label_attr [TwigBridge] bootstrap4 file_widget: Allow set label attributes declared in label_attr Apr 15, 2019

@nicolas-grekas nicolas-grekas changed the title [TwigBridge] bootstrap4 file_widget: Allow set label attributes declared in label_attr [TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr Apr 15, 2019

@nicolas-grekas nicolas-grekas force-pushed the AngelFQC:patch-1 branch from 18e2de3 to 0fd2d86 Apr 15, 2019

@AngelFQC AngelFQC changed the base branch from master to 4.2 Apr 17, 2019

@AngelFQC AngelFQC changed the base branch from 4.2 to master Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.