[TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr #31102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Apr 14, 2019
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 14, 2019
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
nicolas-grekas
changed the title
…eclared in label_attr
fabpot
added a commit
that referenced
this pull request
Apr 27, 2019
…el attributes declared in label_attr (AngelFQC) This PR was submitted for the 4.2 branch but it was merged into the 4.3-dev branch instead (closes #31220). Discussion ---------- [TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr | Q | A | ------------- | --- | Branch? | 4.2 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | ... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | ... <!-- required for new features --> > Bootstrap provides a way to translate the “Browse” text in HTML with the data-browse attribute which can be added to the custom input label. https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-html But currently the attributes declared in label_attr aren't being added. Previously I sent this same change to the master branch (PR #31102), but I think I should have sent it to branch 4.2 Commits ------- 9c76b29 [TwigBridge] bootstrap4 file_widget: allow setting label attributes declared in label_attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getbootstrap.com/docs/4.3/components/forms/#translating-or-customizing-the-strings-with-html
But currently the attributes declared in label_attr aren't being added.