Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)" #31142

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
6 participants
@chalasr
Copy link
Member

commented Apr 17, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #31136
License MIT
Doc PR n/a
Revert "bug #30423 [Security] Rework firewall's access denied rule (d…
…imabory)"

This reverts commit fd1408b, reversing
changes made to b93d2bf.

@chalasr chalasr added the Security label Apr 17, 2019

@chalasr chalasr added this to the 3.4 milestone Apr 17, 2019

@curry684

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

So idea is to push this to 3.4 and 4.2 but not master right? Or should we just delay the real fix until 5.0 is branched?

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

I'm fine with having it in master/4.3.

@curry684

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Yes so we agree the revert should only be in 3.4 and 4.2, and the fix stays in master/4.3 indeed 😄

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

We will need a new PR for master though.

@dimabory

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

We will need a new PR for master though.

@fabpot Should I take over this as an author of #30423?

@curry684

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

You could just resubmit the same PR with the upgrade and changelog notes that will be needed now.

@chalasr

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@dimabory PR welcome with UPGRADE + CHANGELOG entries

@dimabory

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@curry684, @chalasr Actually, the discussion can be moved to #30423 (someone is still commenting there)

@fabpot fabpot merged commit cd77f6f into symfony:3.4 Apr 17, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot pushed a commit that referenced this pull request Apr 17, 2019

bug #31142 Revert "bug #30423 [Security] Rework firewall's access den…
…ied rule (dimabory)" (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | #31136
| License       | MIT
| Doc PR        | n/a

Commits
-------

cd77f6f Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Thank you @chalasr
PR welcome on master now.

@chalasr chalasr deleted the chalasr:revert-30423 branch Apr 17, 2019

This was referenced Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.