Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] Add intltimezone input to TimezoneType #31195

Merged
merged 1 commit into from
Apr 27, 2019
Merged

[Form] Add intltimezone input to TimezoneType #31195

merged 1 commit into from
Apr 27, 2019

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Apr 22, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22302 (ref #28836)
License MIT
Doc PR symfony/symfony-docs#11463

cc @rvanlaak

ro0NL
ro0NL commented Apr 22, 2019
View reviewed changes
src/Symfony/Component/Form/Extension/Core/Type/TimezoneType.php
{
$timezones = [];

foreach (\DateTimeZone::listIdentifiers($regions) as $timezone) {
if ('intltimezone' === $input && 'Etc/Unknown' === \IntlTimeZone::createTimeZone($timezone)->getID()) {
continue;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference, the following PHP timezone IDs become unavailable:

America/Punta_Arenas
Asia/Atyrau
Asia/Famagusta
Asia/Qostanay
Asia/Tomsk
Asia/Yangon
Europe/Kirov
Europe/Saratov

(see https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/metaZones.txt for expiration dates)

@ro0NL ro0NL marked this pull request as ready for review April 22, 2019 08:23
@ro0NL ro0NL mentioned this pull request Apr 22, 2019
Closed
rvanlaak
rvanlaak approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@rvanlaak rvanlaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 23, 2019
@ro0NL ro0NL mentioned this pull request Apr 26, 2019
Merged
xabbuh added a commit that referenced this pull request Apr 27, 2019
@xabbuh
minor #31278 [Form] Fix author tag + exception messages (ro0NL)
f033ea4 
This PR was squashed before being merged into the 3.4 branch (closes #31278).

Discussion
----------

[Form] Fix author tag + exception messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

spotted in #31195 😅

Commits
-------

796f2ff [Form] Fix author tag + exception messages
@fabpot
Copy link
Member

fabpot commented Apr 27, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit e169dfb into symfony:master Apr 27, 2019
fabpot added a commit that referenced this pull request Apr 27, 2019
@fabpot
feature #31195 [Form] Add intltimezone input to TimezoneType (ro0NL)
73d303a 
This PR was squashed before being merged into the 4.3-dev branch (closes #31195).

Discussion
----------

[Form] Add intltimezone input to TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #22302 (ref #28836)
| License       | MIT
| Doc PR        | symfony/symfony-docs#11463

cc @rvanlaak

Commits
-------

e169dfb [Form] Add intltimezone input to TimezoneType
@ro0NL ro0NL deleted the timezone-form branch April 27, 2019 15:21
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@yceruto yceruto yceruto approved these changes

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees
No one assigned
Labels
Feature Form Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
7 participants
@ro0NL @fabpot @javiereguiluz @yceruto @rvanlaak @nicolas-grekas @carsonbot