Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Add intltimezone input to TimezoneType #31195

Merged
merged 1 commit into from Apr 27, 2019

Conversation

Projects
None yet
7 participants
@ro0NL
Copy link
Contributor

commented Apr 22, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22302 (ref #28836)
License MIT
Doc PR symfony/symfony-docs#11463

cc @rvanlaak

{
$timezones = [];
foreach (\DateTimeZone::listIdentifiers($regions) as $timezone) {
if ('intltimezone' === $input && 'Etc/Unknown' === \IntlTimeZone::createTimeZone($timezone)->getID()) {
continue;

This comment has been minimized.

Copy link
@ro0NL

ro0NL Apr 22, 2019

Author Contributor

for reference, the following PHP timezone IDs become unavailable:

America/Punta_Arenas
Asia/Atyrau
Asia/Famagusta
Asia/Qostanay
Asia/Tomsk
Asia/Yangon
Europe/Kirov
Europe/Saratov

(see https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/metaZones.txt for expiration dates)

@ro0NL ro0NL force-pushed the ro0NL:timezone-form branch from f8012f4 to e6d5945 Apr 22, 2019

@ro0NL ro0NL marked this pull request as ready for review Apr 22, 2019

@rvanlaak
Copy link
Contributor

left a comment

👏

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 23, 2019

@ro0NL ro0NL force-pushed the ro0NL:timezone-form branch 2 times, most recently from 9dee433 to 600f673 Apr 25, 2019

@ro0NL ro0NL force-pushed the ro0NL:timezone-form branch 2 times, most recently from c6797d1 to 23350ad Apr 26, 2019

xabbuh added a commit that referenced this pull request Apr 27, 2019

minor #31278 [Form] Fix author tag + exception messages (ro0NL)
This PR was squashed before being merged into the 3.4 branch (closes #31278).

Discussion
----------

[Form] Fix author tag + exception messages

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

spotted in #31195 😅

Commits
-------

796f2ff [Form] Fix author tag + exception messages
@fabpot

fabpot approved these changes Apr 27, 2019

@fabpot fabpot force-pushed the ro0NL:timezone-form branch from 665f929 to e169dfb Apr 27, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

Thank you @ro0NL.

@fabpot fabpot merged commit e169dfb into symfony:master Apr 27, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Apr 27, 2019

feature #31195 [Form] Add intltimezone input to TimezoneType (ro0NL)
This PR was squashed before being merged into the 4.3-dev branch (closes #31195).

Discussion
----------

[Form] Add intltimezone input to TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #22302 (ref #28836)
| License       | MIT
| Doc PR        | symfony/symfony-docs#11463

cc @rvanlaak

Commits
-------

e169dfb [Form] Add intltimezone input to TimezoneType

@ro0NL ro0NL deleted the ro0NL:timezone-form branch Apr 27, 2019

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.