[Doctrine][PropertyInfo] Detect if the ID is writeable #31486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
pinfo-doctrine-access
branch
from
a0f277a
to
4598235
Compare
sroze
approved these changes
May 12, 2019
maxhelias
approved these changes
May 12, 2019
fabpot
approved these changes
May 13, 2019
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
May 13, 2019
… (dunglas) This PR was merged into the 4.3 branch. Discussion ---------- [Doctrine][PropertyInfo] Detect if the ID is writeable | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a Companion of #31481. Allows to detect that ids with a generated value aren't writable (because the DBMS will generate the ID by itself). It could be considered as a bug fix or as a new feature. I prefer to not merge in in 3.4. However, it becomes necessary for autovalidation to work with such entities, so it should be in 4.3: ```php /** * @entity */ class Foo { /** * @id * @GeneratedValue(strategy="AUTO") * @column(type="integer") */ public $id; } ``` Commits ------- 4598235 [Doctrine][PropertyInfo] Detect if the ID is writeable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of #31481. Allows to detect that ids with a generated value aren't writable (because the DBMS will generate the ID by itself). It could be considered as a bug fix or as a new feature. I prefer to not merge in in 3.4. However, it becomes necessary for autovalidation to work with such entities, so it should be in 4.3: