[Ldap] Add exception for mapping ldap errors #31547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
force-pushed
the
feature/add-ldap-error-code-to-execption
branch
from
7d7d9e4
to
f5cf0eb
Compare
Simperfit
force-pushed
the
feature/add-ldap-error-code-to-execption
branch
2 times, most recently
from
d601edc
to
792fdb4
Compare
src/Symfony/Component/Ldap/Exception/AlreadyExistsException.php
Outdated
Show resolved
Hide resolved
I did do any LDAP for a while. I can not help here. Sorry |
Simperfit
force-pushed
the
feature/add-ldap-error-code-to-execption
branch
from
792fdb4
to
1b29cb1
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Ldap] minor: fix phpdocs in the ldap component | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Fix just some phpdocs highlighted by @nicolas-grekas in #31547. Commits ------- 721915f minor: fix phpdocs in the ldap component
|
@fabpot this is ready |
csarrazi
approved these changes
Jun 21, 2019
|
LGTM 👍 |
fabpot
approved these changes
Jun 22, 2019
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Jun 22, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Ldap] Add exception for mapping ldap errors | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28677 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Maybe we could add more exception code since the list has a lot of errors, maybe we could add a class that maps the error to the right exeptions. see https://www.php.net/manual/en/function.ldap-errno.php Commits ------- 1b29cb1 [Ldap] Add exception for mapping ldap errors
fabpot
added a commit
that referenced
this pull request
Jul 3, 2019
…aviereguiluz) This PR was merged into the 4.4 branch. Discussion ---------- [Ldap] Document the new exceptions thrown by the code | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | not needed While deciding if we should document #31547 I saw that the new exceptions weren't documented in the code. I don't know if this is the place where this should be added. Commits ------- 0d27af9 [Ldap] Document the new exceptions thrown by the code
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we could add more exception code since the list has a lot of errors, maybe we could add a class that maps the error to the right exeptions. see https://www.php.net/manual/en/function.ldap-errno.php