Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Fixed undefined variable in ArrayTrait #31864

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@eXtreme
Copy link
Contributor

commented Jun 5, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

So once again (see #29591) my test suite managed to find an error in ArrayTrait in cache. This time it was this PR: #31395 later improved by #31590 that introduced $id to logging, which I guess should be $key? So this PR changes it to $key, but my tests still fail as there is no $this->namespace in ArrayAdapter (is this the only class that uses this ArrayTrait?). But I don't know what to do about it. Maybe @nicolas-grekas has some answers?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Bad copy/paste in #31590, please remove the namespace.

@eXtreme

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@nicolas-grekas nicolas-grekas force-pushed the eXtreme:patch-1 branch from 49a25e5 to 8568923 Jun 5, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Thank you @eXtreme.

@nicolas-grekas nicolas-grekas merged commit 8568923 into symfony:4.3 Jun 5, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 5, 2019

bug #31864 [Cache] Fixed undefined variable in ArrayTrait (eXtreme)
This PR was squashed before being merged into the 4.3 branch (closes #31864).

Discussion
----------

[Cache] Fixed undefined variable in ArrayTrait

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

So once again (see #29591) my test suite managed to find an error in ArrayTrait in cache. This time it was this PR: #31395 later improved by #31590 that introduced `$id` to logging, which I guess should be `$key`? So this PR changes it to `$key`, ~but my tests **still fail** as there is no `$this->namespace` in `ArrayAdapter` (is this the only class that uses this ArrayTrait?). But I don't know what to do about it. Maybe @nicolas-grekas has some answers?~

Commits
-------

8568923 [Cache] Fixed undefined variable in ArrayTrait

@eXtreme eXtreme deleted the eXtreme:patch-1 branch Jun 5, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.