Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] Pass arg to get callback everywhere #31879

Conversation

Projects
None yet
3 participants
@fancyweb
Copy link
Contributor

commented Jun 5, 2019

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Some adapters does not pass an useless "save" bool arg. However, that makes a CallbackInterface callable unusable with them since the arg is required in the interface.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Jun 5, 2019

@fancyweb fancyweb force-pushed the fancyweb:fix-cache-traceable-adapter-callback-call branch from 957267a to d03eb03 Jun 6, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit d03eb03 into symfony:4.2 Jun 6, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 6, 2019

bug #31879 [Cache] Pass arg to get callback everywhere (fancyweb)
This PR was merged into the 4.2 branch.

Discussion
----------

[Cache] Pass  arg to get callback everywhere

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Some adapters does not pass an useless "save" bool arg. However, that makes a `CallbackInterface` callable unusable with them since the arg is required in the interface.

Commits
-------

d03eb03 [Cache] Pass  arg to get callback everywhere

@fancyweb fancyweb deleted the fancyweb:fix-cache-traceable-adapter-callback-call branch Jun 6, 2019

@fabpot fabpot referenced this pull request Jun 6, 2019

Merged

Release v4.3.1 #31901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.