[Cache] Pass arg to get callback everywhere #31879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Jun 5, 2019
fancyweb
commented
Jun 5, 2019
fancyweb
force-pushed
the
fix-cache-traceable-adapter-callback-call
branch
from
957267a
to
d03eb03
Compare
nicolas-grekas
approved these changes
Jun 6, 2019
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 6, 2019
This PR was merged into the 4.2 branch. Discussion ---------- [Cache] Pass arg to get callback everywhere | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Some adapters does not pass an useless "save" bool arg. However, that makes a `CallbackInterface` callable unusable with them since the arg is required in the interface. Commits ------- d03eb03 [Cache] Pass arg to get callback everywhere
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 21, 2023
…c expiration handler (AdamKatzDev) This PR was merged into the 5.4 branch. Discussion ---------- [Cache][Messenger] fixed CallbackInterface support in async expiration handler | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Adds support for CallbackInterface in EarlyExpirationHandler and thus fixes async cache recomputing for callables that implement CallbackInterface. Earlier similar errors were fixed in #31879. Commits ------- a8dea95 [Messenger][Cache] fixed CallbackInterface support in async expiration handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adapters does not pass an useless "save" bool arg. However, that makes a
CallbackInterfacecallable unusable with them since the arg is required in the interface.