Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] make Psr18Client implement relevant PSR-17 factories #31980

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This should help use the component with libs that consume only PSR-18.

@stof

stof approved these changes Jun 11, 2019

@fabpot

fabpot approved these changes Jun 11, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 1c0baf6 into symfony:4.4 Jun 11, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 11, 2019

feature #31980 [HttpClient] make Psr18Client implement relevant PSR-1…
…7 factories (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] make Psr18Client implement relevant PSR-17 factories

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This should help use the component with libs that consume only PSR-18.

Commits
-------

1c0baf6 [HttpClient] make Psr18Client implement relevant PSR-17 factories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.