Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2 #31976

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Jun 10, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR symfony/symfony-docs#11820

Many libs still depend on httplug:
https://packagist.org/packages/php-http/client-implementation/dependents

Until they're all updated to PSR-18 or SFContracts, this PR provides an adapter for injecting a Symfony HttpClient into httplug-compatible classes, v1 or v2.

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 10, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-plug branch from 745b8ab to c7f428a Jun 10, 2019

@Nyholm

Nyholm approved these changes Jun 10, 2019

Copy link
Member

left a comment

Thank you

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-plug branch 4 times, most recently from 31dd764 to f223518 Jun 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Rebased on top of #31980, waiting for it to be merged before this one.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-plug branch 2 times, most recently from bbe103b to 27b138c Jun 10, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

(rebased)

@stof

stof approved these changes Jun 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:hc-plug branch from 27b138c to 28674b1 Jun 11, 2019

@nicolas-grekas nicolas-grekas merged commit 28674b1 into symfony:4.4 Jun 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 11, 2019

feature #31976 [HttpClient] add HttplugClient for compat with libs th…
…at need httplug v1 or v2 (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Many libs still depend on httplug:
https://packagist.org/packages/php-http/client-implementation/dependents

Until they're all updated to PSR-18 or SFContracts, this PR provides an adapter for injecting a Symfony HttpClient into httplug-compatible classes, v1 or v2.

Commits
-------

28674b1 [HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-plug branch Jun 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

I used this PR to merge itself, worked like a charm :)

@nicolas-grekas nicolas-grekas restored the nicolas-grekas:hc-plug branch Jun 12, 2019

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:hc-plug branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.