Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DebugBundle] fix register ReflectionCaster::unsetClosureFileInfo caster in var cloner service #32129

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

alekitto
Copy link
Contributor

Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Non-existent class was checked by method_exists in Debug bundle.
This should fix (and correctly register) the caster while loading DebugExtension from DebugBundle

@nicolas-grekas
Copy link
Member

Good catch, thanks @alekitto.

@nicolas-grekas nicolas-grekas merged commit 860164e into symfony:4.3 Jun 23, 2019
nicolas-grekas added a commit that referenced this pull request Jun 23, 2019
…ileInfo caster in var cloner service (alekitto)

This PR was merged into the 4.3 branch.

Discussion
----------

[DebugBundle] fix register ReflectionCaster::unsetClosureFileInfo caster in var cloner service

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Non-existent class was checked by `method_exists` in Debug bundle.
This should fix (and correctly register) the caster while loading `DebugExtension` from `DebugBundle`

Commits
-------

860164e [DebugBundle] fix register ReflectionCaster::unsetClosureFileInfo caster in var cloner service
@fabpot fabpot mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants