[Messenger] Use ConnectionRegistry instead of RegistryInterface #32354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 4, 2019
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2019
…terface (derrabus) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Use ConnectionRegistry instead of RegistryInterface | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A This PR changes the constructor type-hint on `DoctrineTransportFactory` from `Symfony\Bridge\Doctrine\RegistryInterface` to the smaller `Doctrine\Common\Persistence\ConnectionRegistry`. Since we only call the `getConnection()` method, this interface is sufficient. This change allows to use the factory without the Doctrine bridge and makes it easier to use it stand-alone. Commits ------- ce6a5ad Use ConnectionRegistry instead of RegistryInterface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the constructor type-hint on
DoctrineTransportFactoryfromSymfony\Bridge\Doctrine\RegistryInterfaceto the smallerDoctrine\Common\Persistence\ConnectionRegistry. Since we only call thegetConnection()method, this interface is sufficient.This change allows to use the factory without the Doctrine bridge and makes it easier to use it stand-alone.