Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Use mocks before replacing the error handler #32592

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

greg0ire
Copy link
Contributor

Q A
Branch? 3.4,
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

We want the bridge to mute the php 7.4 deprecations triggered when building mocks.

We want the bridge to mute the deprecations triggered when building mocks.
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jul 18, 2019
@nicolas-grekas
Copy link
Member

Thank you @greg0ire.

@nicolas-grekas nicolas-grekas merged commit f6e0b01 into symfony:3.4 Jul 18, 2019
nicolas-grekas added a commit that referenced this pull request Jul 18, 2019
…eg0ire)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Use mocks before replacing the error handler

| Q             | A
| ------------- | ---
| Branch?       | 3.4,
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

We want the bridge to mute the php 7.4 deprecations triggered when building mocks.

Commits
-------

f6e0b01 Use mocks before replacing the error handler
@greg0ire greg0ire deleted the fix-7-4-deprecation branch July 18, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants