[Intl] Support ISO 3166-1 Alpha-3 country codes #32988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This a continuation of #32676 |
ro0NL
approved these changes
Aug 6, 2019
terjebraten-certua
changed the title
derrabus
requested changes
Aug 7, 2019
|
@derrabus Could you please complete your review? |
|
@terjebraten-certua I'm not familiar enough with the component to approve your changes, but I would trust that @ro0NL's review has been thorough. 😃 Status: Reviewed |
|
@fabpot I did all the changes you requested. |
|
Thank you @terjebraten-certua. |
fabpot
added a commit
that referenced
this pull request
Aug 9, 2019
…braten-certua) This PR was merged into the 4.4 branch. Discussion ---------- [Intl] Support ISO 3166-1 Alpha-3 country codes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20313 | Doc PR | symfony/symfony-docs#12105 | License | MIT This is a pre-requiste for fixing #20313 and only handles the changes to the INTL component. Commits ------- 848f60e Support ISO 3166-1 Alpha-3 country codes
This was referenced Aug 13, 2019
This was referenced Nov 12, 2019
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jan 31, 2020
…axperrimond) This PR was squashed before being merged into the 5.1-dev branch (closes #35116). Discussion ---------- [Validator] Add alpha3 option to country constraint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#12857 A following of #33791 and #32988 to add `alpha3` option also to `Country` constraint in the validator component. Commits ------- d6f34a5 [Validator] Add alpha3 option to country constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requiste for fixing #20313 and only handles the changes to the INTL component.