Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Support ISO 3166-1 Alpha-3 country codes #32988

Merged
merged 1 commit into from Aug 9, 2019
Merged

Conversation

@terjebraten-certua
Copy link
Contributor

terjebraten-certua commented Aug 6, 2019

Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20313
Doc PR symfony/symfony-docs#12105
License MIT

This is a pre-requiste for fixing #20313 and only handles the changes to the INTL component.

@terjebraten-certua

This comment has been minimized.

Copy link
Contributor Author

terjebraten-certua commented Aug 6, 2019

This a continuation of #32676

@ro0NL
ro0NL approved these changes Aug 6, 2019
@terjebraten-certua terjebraten-certua changed the title Support ISO 3166-1 Alpha-3 country codes [Intl] Support ISO 3166-1 Alpha-3 country codes Aug 6, 2019
@nicolas-grekas nicolas-grekas added this to the next milestone Aug 7, 2019
@terjebraten-certua

This comment has been minimized.

Copy link
Contributor Author

terjebraten-certua commented Aug 8, 2019

@derrabus Could you please complete your review?

@derrabus

This comment has been minimized.

Copy link
Contributor

derrabus commented Aug 8, 2019

@terjebraten-certua I'm not familiar enough with the component to approve your changes, but I would trust that @ro0NL's review has been thorough. 😃

Status: Reviewed

@fabpot
fabpot approved these changes Aug 9, 2019
Copy link
Member

fabpot left a comment

with some minor CS comments

src/Symfony/Component/Intl/Countries.php Outdated Show resolved Hide resolved
src/Symfony/Component/Intl/Countries.php Outdated Show resolved Hide resolved
src/Symfony/Component/Intl/Countries.php Outdated Show resolved Hide resolved
src/Symfony/Component/Intl/Languages.php Outdated Show resolved Hide resolved
src/Symfony/Component/Intl/Languages.php Outdated Show resolved Hide resolved
@terjebraten-certua

This comment has been minimized.

Copy link
Contributor Author

terjebraten-certua commented Aug 9, 2019

@fabpot I did all the changes you requested.

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Aug 9, 2019

Thank you @terjebraten-certua.

@fabpot fabpot merged commit 848f60e into symfony:4.4 Aug 9, 2019
2 of 3 checks passed
2 of 3 checks passed
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabpot added a commit that referenced this pull request Aug 9, 2019
…braten-certua)

This PR was merged into the 4.4 branch.

Discussion
----------

[Intl] Support ISO 3166-1 Alpha-3 country codes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20313
| Doc PR | symfony/symfony-docs#12105
| License       | MIT

This is a pre-requiste for fixing #20313 and only handles the changes to the INTL component.

Commits
-------

848f60e Support ISO 3166-1 Alpha-3 country codes
@TerjeBr

This comment has been minimized.

Copy link

TerjeBr commented Aug 13, 2019

@ro0NL Please have a look at #33136

fabpot added a commit that referenced this pull request Jan 31, 2020
…axperrimond)

This PR was squashed before being merged into the 5.1-dev branch (closes #35116).

Discussion
----------

[Validator] Add alpha3 option to country constraint

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#12857

A following of #33791 and #32988 to add `alpha3` option also to `Country` constraint in the validator component.

Commits
-------

d6f34a5 [Validator] Add alpha3 option to country constraint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.