Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ForwardCompatTestTrait #33048

Merged

Conversation

@jderusse
Copy link
Contributor

commented Aug 8, 2019

Q A
Branch? 5.0
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets NA
License MIT
Doc PR NA

Removes ForwardCompatTestTrait not needed anymore, and use the PHPUnit 8 signature on methods setUp and tearDown

@jderusse jderusse force-pushed the jderusse:remove-ForwardCompatTestTrait branch 2 times, most recently from 68fae03 to a69ccae Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:remove-ForwardCompatTestTrait branch from a69ccae to 4e76a09 Aug 8, 2019

@jderusse jderusse requested a review from xabbuh as a code owner Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:remove-ForwardCompatTestTrait branch 2 times, most recently from ca61d86 to 0c5eb92 Aug 8, 2019

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Aug 8, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

rebase needed

@jderusse jderusse force-pushed the jderusse:remove-ForwardCompatTestTrait branch 2 times, most recently from 2df485c to 0be6930 Aug 8, 2019

@jderusse jderusse force-pushed the jderusse:remove-ForwardCompatTestTrait branch from 0be6930 to 242786c Aug 8, 2019

@jderusse

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

fail test not related to this PR. (fixed in #33051)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 242786c into symfony:master Aug 8, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 8, 2019

minor #33048 Remove ForwardCompatTestTrait (jderusse)
This PR was merged into the 5.0-dev branch.

Discussion
----------

Remove ForwardCompatTestTrait

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | NA
| License       | MIT
| Doc PR        | NA

Removes ForwardCompatTestTrait not needed anymore, and use the PHPUnit 8 signature on methods `setUp` and `tearDown`

Commits
-------

242786c Remove ForwardCompatTestTrait

nicolas-grekas added a commit that referenced this pull request Aug 9, 2019

minor #33080 Update UPGRADE file to indicate method signature changed…
… (jderusse)

This PR was merged into the 4.4 branch.

Discussion
----------

Update UPGRADE file to indicate method signature changed

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Followup #33048

Commits
-------

56d5d6d Add deprecation for method signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.