Remove ForwardCompatTestTrait #33048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
remove-ForwardCompatTestTrait
branch
2 times, most recently
from
68fae03
to
a69ccae
Compare
derrabus
approved these changes
Aug 8, 2019
jderusse
force-pushed
the
remove-ForwardCompatTestTrait
branch
from
a69ccae
to
4e76a09
Compare
jderusse
force-pushed
the
remove-ForwardCompatTestTrait
branch
2 times, most recently
from
ca61d86
to
0c5eb92
Compare
|
rebase needed |
jderusse
force-pushed
the
remove-ForwardCompatTestTrait
branch
2 times, most recently
from
2df485c
to
0be6930
Compare
jderusse
force-pushed
the
remove-ForwardCompatTestTrait
branch
from
0be6930
to
242786c
Compare
Simperfit
approved these changes
Aug 8, 2019
nicolas-grekas
approved these changes
Aug 8, 2019
seriquynh
approved these changes
Aug 8, 2019
|
fail test not related to this PR. (fixed in #33051) |
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- Remove ForwardCompatTestTrait | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA Removes ForwardCompatTestTrait not needed anymore, and use the PHPUnit 8 signature on methods `setUp` and `tearDown` Commits ------- 242786c Remove ForwardCompatTestTrait
nicolas-grekas
added a commit
that referenced
this pull request
Aug 9, 2019
… (jderusse) This PR was merged into the 4.4 branch. Discussion ---------- Update UPGRADE file to indicate method signature changed | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Followup #33048 Commits ------- 56d5d6d Add deprecation for method signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ForwardCompatTestTrait not needed anymore, and use the PHPUnit 8 signature on methods
setUpandtearDown