[Intl] make polyfill classes abstract, fix edge case #33275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
intl-clean
branch
from
adc92ee
to
c757b95
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
…las-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [Intl] make polyfill classes abstract, fix edge case | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While working on return types, I keep stumbling on those classes that are `@internal`, but for which we must not add return types, because they're polyfills and are extended by stubs found in the `Resources` folder of the component. Making the polyfills abstract fixes the linting issue. This made me discover we have a glitch in the `getPattern()` implementation, that makes our version diverge from intl's. Fixed here too. On 4.4 because let's not disrupt 3.4. Commits ------- c757b95 [Intl] make polyfill classes abstract, fix edge case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on return types, I keep stumbling on those classes that are
@internal, but for which we must not add return types, because they're polyfills and are extended by stubs found in theResourcesfolder of the component.Making the polyfills abstract fixes the linting issue.
This made me discover we have a glitch in the
getPattern()implementation, that makes our version diverge from intl's. Fixed here too.On 4.4 because let's not disrupt 3.4.