-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifier Component #33687
Notifier Component #33687
Conversation
f4662b8
to
a55762b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor CS so far ;)
src/Symfony/Component/Notifier/EventListener/SendFailedMessageToNotifierListener.php
Show resolved
Hide resolved
src/Symfony/Component/Notifier/EventListener/NotificationLoggerListener.php
Show resolved
Hide resolved
src/Symfony/Component/Notifier/EventListener/SendFailedMessageToNotifierListener.php
Outdated
Show resolved
Hide resolved
e25fd0f
to
47c4b0a
Compare
5ccdc2c
to
af4fba6
Compare
@fabpot @nicolas-grekas Side question: why are you amending changes all the time? In this case it's impossible to see changes introduced on each step of the review process, so when new version of a branch is pushed I don't know what should be reviewed again (Github marks whole files as "changed since last view", with large files it's difficult to read whole file every time). I recommend adding new commits and squash them just before merging, if you want to keep compact history. Edit: ahh, Github generates |
For some reasons, some of my comments were not published :( |
@Wirone About providers that could be implemented: this initial PR provides just a few of the possible/popular providers to get us started. I hope that many other ones will be submitted over time. Regarding |
2554b5c
to
0b219b9
Compare
0b219b9
to
7f97a3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and accept followups to tweak the rest, add tests, etc.
Help wanted!
Thanks @fabpot for working on this feature, this is much appreciated. |
This PR was merged into the 5.0-dev branch. Discussion ---------- Notifier Component | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | not yet Initial PR for the Notifier component. Tests missing for now. Commits ------- 7f97a3f [Notifier] added the component
This PR was squashed before being merged into the 5.0 branch (closes #34549). Discussion ---------- [Notifier] Add Slack bridge tests | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | See #33687 | License | MIT Adds tests for the Slack bridge of the Notifier component. #SymfonyHackday Commits ------- 626fdaa [Notifier] Add Slack bridge tests
This PR was squashed before being merged into the 5.0 branch (closes #34539). Discussion ---------- [Notifier] Add telegram tests | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | See #33687 | License | MIT Adds tests for the Telegram bridge of the Notifier component. Not sure if this is the right way to go, but would love some feedback. #SymfonyHackday Commits ------- 3b4d83c [Notifier] Add telegram tests
This PR was merged into the 5.1-dev branch. Discussion ---------- Add Mattermost notifier bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | See #33687 | License | MIT | Doc PR | Added a http://mattermost.org (open source Slack alternative) transport for the new Notifier component Commits ------- eaba6a5 Add Mattermost notifier bridge
This PR was squashed before being merged into the 5.1-dev branch (closes #34022). Discussion ---------- [Notifier] add RocketChat bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | See #33687 | License | MIT This would add [RocketChat](https://rocket.chat/) integration for the Notifier component. RocketChat is a self hosted chat service. Fully tested with a trial version of RocketChat. @Wirone I noticed you suggested this. Commits ------- 4869ef6 [Notifier] add RocketChat bridge
This PR was squashed before being merged into the 5.1-dev branch (closes #33968). Discussion ---------- [Notifier] Add Firebase bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | See #33687 | License | MIT This would add [Firebase](https://firebase.google.com) integration for the Notifier component. With Firebase you can send push notifications to the users of you Android and iOS app and website (formerly known as Google Cloud messaging). I'm not sure if it's possible to have this merged, like the other bridges. Or if I should create a stand-alone repository? That'd be fine too. Also it's now using the `ChatMessage` as implementation of `Symfony\Component\Notifier\Message\MessageInterface`, but I feel like this component could use a `PushMessage` or something similar. Although I'm not sure if it would contain more than `subject` that the `ChatMessage` does. Commits ------- 2776d2f [Notifier] Add Firebase bridge
This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- [Notifier] add OvhCloud bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | See #33687 | License | MIT This would add OvhCloud sms integration for the Notifier component. Tested with 'ovh-eu' entrypoint. Inspiration : https://github.com/ovh/php-ovh Commits ------- 76bfb85 [Notifier] add OvhCloud bridge
This PR was merged into the 5.2-dev branch. Discussion ---------- [Notifier] Add Zulip notifier bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | See #33687 | License | MIT | Doc PR | symfony/symfony-docs#13604 This adds a [Zulip](https://zulipchat.com/) (another popular open source Slack alternative) transport for the new Notifier component. #### Sample DSN ```ZULIP_DSN=zulip://test-bot@zulipchat.com:api-key@example.zulipchat.com?channel=builds``` #### Configuration ```yml # config/packages/notifier.yaml framework: notifier: chatter_transports: zulip: '%env(ZULIP_DSN)%' ``` #### Example ```php public function index(ChatterInterface $chatter) { $message = (new ChatMessage('New order arrived!', new ZulipOptions('Ordering'))) ->transport('zulip'); $chatter->send($message); ... } ``` Commits ------- bd4fd32 Adds Zulip notifier bridge
This PR was merged into the 5.2-dev branch. Discussion ---------- [Notifier] Add Mobyt bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #33687 | License | MIT | Doc PR | symfony/symfony-docs#13606 | recipe PR | symfony/recipes#768 Add Mobyt notifier bridge. In this SMS Provider, you can choose a sort of "quality service" to send the message. I updated `src/Symfony/Component/Notifier/Message/SmsMessage.php` to add the notification in order to be able to use the notification importance when creating options. Commits ------- bf594b7 Add Mobyt Notifier bridge
Initial PR for the Notifier component. Tests missing for now.