Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Notifier Component #33687
Wirone left a comment
25 cents from me
Additional suggestions and/or thoughts:
@fabpot @nicolas-grekas Side question: why are you amending changes all the time? In this case it's impossible to see changes introduced on each step of the review process, so when new version of a branch is pushed I don't know what should be reviewed again (Github marks whole files as "changed since last view", with large files it's difficult to read whole file every time). I recommend adding new commits and squash them just before merging, if you want to keep compact history.
Edit: ahh, Github generates
@Wirone About providers that could be implemented: this initial PR provides just a few of the possible/popular providers to get us started. I hope that many other ones will be submitted over time.
This PR was merged into the 5.0-dev branch. Discussion ---------- Notifier Component | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | | License | MIT | Doc PR | not yet Initial PR for the Notifier component. Tests missing for now. Commits ------- 7f97a3f [Notifier] added the component