Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cache] clean tags folder on invalidation #33930

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@nicolas-grekas
Copy link
Member

commented Oct 9, 2019

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

/cc @andrerom for review :)

@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Oct 9, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-clean-tags branch from ff212a0 to 6bae58d Oct 9, 2019
@andrerom

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Should it pass? :)

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-clean-tags branch from 6bae58d to fadf499 Oct 9, 2019
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:cache-clean-tags branch from fadf499 to b377e41 Oct 9, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

it does :)

nicolas-grekas added a commit that referenced this pull request Oct 9, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

[Cache] clean tags folder on invalidation

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

/cc @andrerom for review :)

Commits
-------

b377e41 [Cache] clean tags folder on invalidation
@nicolas-grekas nicolas-grekas merged commit b377e41 into symfony:4.3 Oct 9, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:cache-clean-tags branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.